Calculate numberOfActiveFilters directly inside initializer

Author: itsmeichigo

Modules/Sources/Yosemite/Model/Bookings/StoredBookingFilters.swift

@@ -6,7 +6,7 @@ import Codegen
 ///
 public struct StoredBookingFilters: Codable, Equatable, GeneratedFakeable {
 
-    /// SiteID: BookingFilters
+    /// SiteID: Booking Filters
     public let filters: [Int64: Filters]
 
     public init(filters: [Int64: Filters]) {
@@ -20,6 +20,7 @@ public struct StoredBookingFilters: Codable, Equatable, GeneratedFakeable {
         public let paymentStatuses: [BookingStatus]
         public let customers: [BookingCustomerFilter]
         public let dateRange: BookingDateRangeFilter?
+        public let numberOfActiveFilters: Int
 
         public init(teamMembers: [BookingTeamMemberFilter],
                     products: [BookingProductFilter],
@@ -33,30 +34,29 @@ public struct StoredBookingFilters: Codable, Equatable, GeneratedFakeable {
             self.paymentStatuses = paymentStatuses
             self.customers = customers
             self.dateRange = dateRange
-        }
-
-        public func numberOfActiveFilters() -> Int {
-            var total = 0
-            if teamMembers.isNotEmpty {
-                total += 1
-            }
-            if products.isNotEmpty {
-                total += 1
-            }
-            if attendanceStatuses.isNotEmpty {
-                total += 1
-            }
-            if customers.isNotEmpty {
-                total += 1
-            }
-            if paymentStatuses.isNotEmpty {
-                total += 1
-            }
-            if dateRange != nil {
-                total += 1
-            }
+            self.numberOfActiveFilters = {
+                var total = 0
+                if teamMembers.isNotEmpty {
+                    total += 1
+                }
+                if products.isNotEmpty {
+                    total += 1
+                }
+                if attendanceStatuses.isNotEmpty {
+                    total += 1
+                }
+                if customers.isNotEmpty {
+                    total += 1
+                }
+                if paymentStatuses.isNotEmpty {
+                    total += 1
+                }
+                if dateRange != nil {
+                    total += 1
+                }
 
-            return total
+                return total
+            }()
         }
     }
 }

WooCommerce/Classes/Bookings/BookingList/BookingListContainerViewModel.swift

@@ -135,7 +135,7 @@ private extension BookingListContainerViewModel {
                 paymentStatuses: storedFilters.paymentStatuses,
                 customers: storedFilters.customers,
                 dateRange: storedFilters.dateRange,
-                numberOfActiveFilters: storedFilters.numberOfActiveFilters()
+                numberOfActiveFilters: storedFilters.numberOfActiveFilters
             )
             updateFilters(filters, shouldPersist: false)
         }