Refactor POS tab: separate visibility and eligibility logic while removing POS as a tab i2 feature flag (#16173)

Author: jaclync

Modules/Sources/Experiments/DefaultFeatureFlagService.swift

@@ -86,8 +86,6 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
             return false
         case .productImageOptimizedHandling:
             return true
-        case .pointOfSaleAsATabi2:
-            return true
         case .pointOfSaleOrdersi1:
             return true
         case .pointOfSaleOrdersi2:

Modules/Sources/Experiments/FeatureFlag.swift

@@ -179,10 +179,6 @@ public enum FeatureFlag: Int {
     ///
     case inventoryProductLabelsInPOS
 
-    /// Enables displaying POS as a tab in the tab bar for stores in eligible countries
-    ///
-    case pointOfSaleAsATabi2
-
     /// Enables displaying Point Of Sale details in order list and order details
     ///
     case pointOfSaleOrdersi1

Modules/Sources/Yosemite/Tools/Plugins/PluginsService.swift

@@ -1,17 +1,8 @@
 import Foundation
-import WooFoundation
 import protocol Storage.StorageManagerType
 
 /// A service for system plugins.
 public protocol PluginsServiceProtocol {
-    /// Waits for a specific plugin to be available in storage.
-    /// - Parameters:
-    ///   - siteID: The site ID to search for the plugin.
-    ///   - pluginPath: The plugin's file path (e.g., "woocommerce/woocommerce.php" for WooCommerce).
-    ///   - isActive: Whether the plugin is active or not.
-    /// - Returns: The SystemPlugin when found in storage.
-    func waitForPluginInStorage(siteID: Int64, pluginPath: String, isActive: Bool) async -> SystemPlugin
-
     /// Loads a specific plugin from storage synchronously.
     /// - Parameters:
     ///   - siteID: The site ID to search for the plugin.
@@ -37,36 +28,6 @@ public class PluginsService: PluginsServiceProtocol {
         self.storageManager = storageManager
     }
 
-    @MainActor
-    public func waitForPluginInStorage(siteID: Int64, pluginPath: String, isActive: Bool) async -> SystemPlugin {
-        let predicate = \StorageSystemPlugin.siteID == siteID && \StorageSystemPlugin.plugin == pluginPath && \StorageSystemPlugin.active == isActive
-        let pluginDescriptor = NSSortDescriptor(keyPath: \StorageSystemPlugin.plugin, ascending: true)
-        let resultsController = ResultsController<StorageSystemPlugin>(storageManager: storageManager,
-                                                                       matching: predicate,
-                                                                       fetchLimit: 1,
-                                                                       sortedBy: [pluginDescriptor])
-        do {
-            try resultsController.performFetch()
-            if let plugin = resultsController.fetchedObjects.first {
-                return plugin
-            }
-        } catch {
-            DDLogError("Error loading plugin \(pluginPath) for site \(siteID) initially: \(error.localizedDescription)")
-        }
-
-        return await withCheckedContinuation { continuation in
-            var hasResumed = false
-            resultsController.onDidChangeContent = {
-                guard let plugin = resultsController.fetchedObjects.first,
-                      !hasResumed else {
-                    return
-                }
-                hasResumed = true
-                continuation.resume(returning: plugin)
-            }
-        }
-    }
-
     @MainActor
     public func loadPluginInStorage(siteID: Int64, plugin: Plugin, isActive: Bool?) -> SystemPlugin? {
         storageManager.viewStorage.loadSystemPlugin(siteID: siteID,

Modules/Tests/YosemiteTests/Tools/Plugins/PluginsServiceTests.swift

@@ -13,40 +13,6 @@ struct PluginsServiceTests {
         sut = PluginsService(storageManager: storageManager)
     }
 
-    @Test func waitForPluginInStorage_returns_plugin_when_already_in_storage() async {
-        // Given
-        await storageManager.reset()
-        storageManager.insertPlugin(siteID: siteID, plugin: .wooCommerce, isActive: true, version: "1.0.0")
-
-        // When
-        let result = await sut.waitForPluginInStorage(siteID: siteID, pluginPath: "woocommerce/woocommerce.php", isActive: true)
-
-        // Then
-        #expect(result.siteID == siteID)
-        #expect(result.plugin == "woocommerce/woocommerce.php")
-        #expect(result.active == true)
-        #expect(result.version == "1.0.0")
-    }
-
-    @Test func waitForPluginInStorage_waits_to_return_plugin_when_not_in_storage_initially() async {
-        // Given
-        // Resets any existing state, otherwise test might fail if run multiple times.
-        await storageManager.reset()
-
-        // When
-        async let plugin = sut.waitForPluginInStorage(siteID: siteID, pluginPath: "woocommerce/woocommerce.php", isActive: true)
-        #expect(storageManager.viewStorage.loadSystemPlugins(siteID: siteID).count == 0)
-        storageManager.insertPlugin(siteID: siteID, plugin: .wooCommerce, isActive: true, version: "2.0.0")
-        #expect(storageManager.viewStorage.loadSystemPlugins(siteID: siteID).count == 1)
-
-        // Then
-        let result = await plugin
-        #expect(result.siteID == siteID)
-        #expect(result.plugin == "woocommerce/woocommerce.php")
-        #expect(result.active == true)
-        #expect(result.version == "2.0.0")
-    }
-
     // MARK: - `loadPluginInStorage`
 
     @Test(arguments: [(Plugin.wooCommerce, true, "1.5.0"),

WooCommerce/Classes/POS/Analytics/WooAnalyticsEvent+PointOfSaleIneligibleUI.swift

@@ -26,10 +26,6 @@ private extension POSIneligibleReason {
             return "feature_switch_disabled"
         case .wooCommercePluginNotFound:
             return "unknown_wc_plugin"
-        case .unsupportedIOSVersion:
-            return "ios_version"
-        case .unsupportedInCIABSites:
-            return "feature_unsupported_in_ciab"
         case .siteSettingsNotAvailable,
              .selfDeallocated:
             return "other"

WooCommerce/Classes/POS/Controllers/POSEntryPointController.swift

@@ -1,20 +1,19 @@
 import SwiftUI
-import protocol Experiments.FeatureFlagService
+
+protocol POSEntryPointEligibilityCheckerProtocol {
+    /// Determines whether the site is eligible for POS.
+    func checkEligibility() async -> POSEligibilityState
+    /// Refreshes the eligibility state based on the provided ineligible reason.
+    func refreshEligibility(ineligibleReason: POSIneligibleReason) async throws -> POSEligibilityState
+}
 
 @Observable final class POSEntryPointController {
     private(set) var eligibilityState: POSEligibilityState?
     private let posEligibilityChecker: POSEntryPointEligibilityCheckerProtocol
-    private let featureFlagService: POSFeatureFlagProviding
 
-    init(eligibilityChecker: POSEntryPointEligibilityCheckerProtocol,
-         featureFlagService: POSFeatureFlagProviding) {
+    init(eligibilityChecker: POSEntryPointEligibilityCheckerProtocol) {
         self.posEligibilityChecker = eligibilityChecker
-        self.featureFlagService = featureFlagService
 
-        guard featureFlagService.isFeatureFlagEnabled(.pointOfSaleAsATabi2) else {
-            self.eligibilityState = .eligible
-            return
-        }
         Task { @MainActor in
             eligibilityState = await posEligibilityChecker.checkEligibility()
         }

WooCommerce/Classes/POS/Models/POSIneligibleReason.swift

@@ -4,14 +4,12 @@ import enum WooFoundation.CurrencyCode
 
 /// Represents the reasons why a site may be ineligible for POS.
 enum POSIneligibleReason: Equatable {
-    case unsupportedIOSVersion
     case unsupportedWooCommerceVersion(minimumVersion: String)
     case siteSettingsNotAvailable
     case wooCommercePluginNotFound
     case featureSwitchDisabled
     case unsupportedCurrency(countryCode: CountryCode, supportedCurrencies: [CurrencyCode])
     case selfDeallocated
-    case unsupportedInCIABSites
 }
 
 /// Represents the eligibility state for POS.

WooCommerce/Classes/POS/Models/PointOfSaleSettingsController.swift

@@ -89,19 +89,6 @@ final class MockPointOfSaleSettingsService: PointOfSaleSettingsServiceProtocol {
 }
 
 final class PluginsServicePreview: PluginsServiceProtocol {
-    func waitForPluginInStorage(siteID: Int64, pluginPath: String, isActive: Bool) async -> SystemPlugin {
-        return SystemPlugin(siteID: 1234,
-                            plugin: "",
-                            name: "",
-                            version: "",
-                            versionLatest: "",
-                            url: "",
-                            authorName: "",
-                            authorUrl: "",
-                            networkActivated: false,
-                            active: true)
-    }
-
     func loadPluginInStorage(siteID: Int64, plugin: Plugin, isActive: Bool?) -> SystemPlugin? {
         return SystemPlugin(siteID: 1234,
                             plugin: "",

WooCommerce/Classes/POS/Presentation/PointOfSaleEntryPointView.swift

@@ -56,7 +56,7 @@ struct PointOfSaleEntryPointView: View {
         self.searchHistoryService = searchHistoryService
         self.popularPurchasableItemsController = popularPurchasableItemsController
         self.barcodeScanService = barcodeScanService
-        self.posEntryPointController = POSEntryPointController(eligibilityChecker: posEligibilityChecker, featureFlagService: services.featureFlags)
+        self.posEntryPointController = POSEntryPointController(eligibilityChecker: posEligibilityChecker)
         self.orderListModel = POSOrderListModel(ordersController: ordersController, receiptSender: receiptSender)
         self.siteTimezone = siteTimezone
         self.services = services
@@ -129,7 +129,7 @@ struct PointOfSaleEntryPointView: View {
                               searchHistoryService: PointOfSalePreviewHistoryService(),
                               popularPurchasableItemsController: PointOfSalePreviewItemsController(),
                               barcodeScanService: PointOfSalePreviewBarcodeScanService(),
-                              posEligibilityChecker: POSTabEligibilityChecker(site: .defaultMock()),
+                              posEligibilityChecker: POSTabEligibilityChecker(siteID: 1),
                               services: POSPreviewServices())
 }
 

WooCommerce/Classes/POS/TabBar/POSIneligibleView.swift

@@ -112,10 +112,6 @@ struct POSIneligibleView: View {
 
     private var suggestionText: String {
         switch reason {
-        case .unsupportedIOSVersion:
-            return NSLocalizedString("pos.ineligible.suggestion.unsupportedIOSVersion.1",
-                                     value: "The POS system requires iOS 17 or later. Please update your device to iOS 17+ to use this feature.",
-                                     comment: "Suggestion for unsupported iOS version: update iOS")
         case let .unsupportedWooCommerceVersion(minimumVersion):
             let format = NSLocalizedString("pos.ineligible.suggestion.unsupportedWooCommerceVersion",
                                      value: "Your WooCommerce version is not supported. " +
@@ -155,12 +151,6 @@ struct POSIneligibleView: View {
             return NSLocalizedString("pos.ineligible.suggestion.selfDeallocated",
                                      value: "Try relaunching the app to resolve this issue.",
                                      comment: "Suggestion for self deallocated: relaunch")
-        case .unsupportedInCIABSites:
-            return NSLocalizedString(
-                "pos.ineligible.suggestion.notSupportedForCIAB",
-                value: "The POS system is not supported for your store.",
-                comment: "Suggestion for CIAB sites: feature is not supported"
-            )
         }
     }
 }
@@ -184,9 +174,6 @@ private extension POSIneligibleView {
 private extension POSIneligibleReason {
     var shouldShowRetryButton: Bool {
         switch self {
-        case .unsupportedIOSVersion,
-                .unsupportedInCIABSites:
-            return false
         case .unsupportedWooCommerceVersion,
                 .siteSettingsNotAvailable,
                 .wooCommercePluginNotFound,
@@ -205,8 +192,7 @@ private extension POSIneligibleReason {
                 value: "Enable POS feature",
                 comment: "Button title to enable the POS feature switch and refresh POS eligibility check"
             )
-        case .unsupportedIOSVersion,
-                .unsupportedWooCommerceVersion,
+        case .unsupportedWooCommerceVersion,
                 .siteSettingsNotAvailable,
                 .wooCommercePluginNotFound,
                 .unsupportedCurrency,
@@ -216,9 +202,6 @@ private extension POSIneligibleReason {
                 value: "Retry",
                 comment: "Button title to refresh POS eligibility check"
             )
-        case .unsupportedInCIABSites:
-            assertionFailure("Retry button should not be shown for `unsupportedInCIABSites`")
-            return String()
         }
     }
 }
@@ -234,15 +217,6 @@ private extension POSIneligibleReason {
     }
 }
 
-#Preview("Unsupported iOS version") {
-    if #available(iOS 17.0, *) {
-        POSIneligibleView(
-            reason: .unsupportedIOSVersion,
-            onRefresh: {}
-        )
-    }
-}
-
 #Preview("WooCommerce plugin not found") {
     if #available(iOS 17.0, *) {
         POSIneligibleView(