Remove unused analytics parameter

Author: staskus

WooCommerce/Classes/POS/Controllers/POSOrderListController.swift

@@ -31,7 +31,6 @@ protocol POSSearchingOrderListControllerProtocol: POSOrderListControllerProtocol
     private var cachedOrders: [POSOrder] = []
     private(set) var selectedOrder: POSOrder?
     private let orderListFetchStrategyFactory: POSOrderListFetchStrategyFactoryProtocol
-    private let analytics: POSAnalyticsProviding
     private var paginationTracker: AsyncPaginationTracker {
         if let existing = strategyPaginationTracker[fetchStrategy.id] {
              return existing
@@ -42,11 +41,9 @@ protocol POSSearchingOrderListControllerProtocol: POSOrderListControllerProtocol
     }
 
     init(orderListFetchStrategyFactory: POSOrderListFetchStrategyFactoryProtocol,
-         analytics: POSAnalyticsProviding,
          initialState: POSOrderListState = .loading([])) {
         self.ordersViewState = initialState
         self.orderListFetchStrategyFactory = orderListFetchStrategyFactory
-        self.analytics = analytics
         self.fetchStrategy = orderListFetchStrategyFactory.defaultStrategy()
     }
 

WooCommerce/Classes/POS/TabBar/POSTabCoordinator.swift

@@ -214,8 +214,7 @@ private extension POSTabCoordinator {
                             appPasswordSupportState: isAppPasswordSupported,
                             currencyFormatter: CurrencyFormatter(currencySettings: currencySettings),
                             analytics: POSOrderListFetchAnalytics(analytics: serviceAdaptor.analytics)
-                        ),
-                        analytics: serviceAdaptor.analytics
+                        )
                     ),
 
                     onPointOfSaleModeActiveStateChange: { [weak self] isEnabled in

WooCommerce/WooCommerceTests/POS/Controllers/POSOrderListControllerTests.swift

@@ -9,8 +9,7 @@ import struct Yosemite.POSOrder
 final class POSOrderListControllerTests {
     private let orderListService = MockPOSOrderListService()
     private lazy var fetchStrategyFactory = MockPOSOrderListFetchStrategyFactory(orderService: orderListService)
-    private lazy var sut = POSOrderListController(orderListFetchStrategyFactory: fetchStrategyFactory,
-                                                  analytics: MockPOSAnalytics())
+    private lazy var sut = POSOrderListController(orderListFetchStrategyFactory: fetchStrategyFactory)
 
     @Test func loadOrders_requests_first_page_after_loading_two_pages() async throws {
         try #require(sut.ordersViewState.isLoading)