Remove SystemStatusAction.fetchSystemPluginListWithNameList usage.

Author: jaclync

Modules/Sources/Yosemite/Actions/SystemStatusAction.swift

@@ -12,10 +12,6 @@ public enum SystemStatusAction: Action {
     ///
     case fetchSystemPlugin(siteID: Int64, systemPluginName: String, onCompletion: (SystemPlugin?) -> Void)
 
-    /// Fetch an specific systemPlugin by siteID and name list.
-    ///
-    case fetchSystemPluginListWithNameList(siteID: Int64, systemPluginNameList: [String], onCompletion: (SystemPlugin?) -> Void)
-
     /// Fetch a specific systemPlugin by path.
     ///
     case fetchSystemPluginWithPath(siteID: Int64, pluginPath: String, onCompletion: (SystemPlugin?) -> Void)

Modules/Sources/Yosemite/Model/Mocks/ActionHandlers/MockSystemStatusActionHandler.swift

@@ -19,10 +19,6 @@ struct MockSystemStatusActionHandler: MockActionHandler {
             let filteredSystemPlugin = systemPlugins.first { $0.name == systemPluginName }
             let matchingPlugin = systemPlugins.first { $0.name == systemPluginName && $0.active } ?? filteredSystemPlugin
             onCompletion(matchingPlugin)
-        case .fetchSystemPluginListWithNameList(let siteID, let systemPluginNameList, let onCompletion):
-            let systemPlugins = objectGraph.systemPlugins(for: siteID)
-            let filteredSystemPlugins = systemPlugins.first { systemPluginNameList.contains($0.name) }
-            onCompletion(filteredSystemPlugins)
         case .fetchSystemPluginWithPath(let siteID, let pluginPath, let onCompletion):
             let systemPlugins = objectGraph.systemPlugins(for: siteID)
             let matchingPlugin = systemPlugins.first { $0.plugin == pluginPath }

Modules/Sources/Yosemite/Stores/SystemStatusStore.swift

@@ -31,8 +31,6 @@ public final class SystemStatusStore: Store {
             synchronizeSystemInformation(siteID: siteID, completionHandler: onCompletion)
         case .fetchSystemPlugin(let siteID, let systemPluginName, let onCompletion):
             fetchSystemPlugin(siteID: siteID, systemPluginNameList: [systemPluginName], completionHandler: onCompletion)
-        case .fetchSystemPluginListWithNameList(let siteID, let systemPluginNameList, let onCompletion):
-            fetchSystemPlugin(siteID: siteID, systemPluginNameList: systemPluginNameList, completionHandler: onCompletion)
         case .fetchSystemPluginWithPath(let siteID, let pluginPath, let onCompletion):
             fetchSystemPluginWithPath(siteID: siteID,
                                       pluginPath: pluginPath,

Modules/Tests/YosemiteTests/Stores/SystemStatusStoreTests.swift

@@ -194,31 +194,6 @@ final class SystemStatusStoreTests: XCTestCase {
         XCTAssertNil(fetchedPlugin)
     }
 
-    func test_fetchSystemPluginsList_return_systemPlugins_correctly() {
-        // Given
-        let systemPlugin1 = viewStorage.insertNewObject(ofType: SystemPlugin.self)
-        systemPlugin1.name = "Plugin 1"
-        systemPlugin1.siteID = sampleSiteID
-
-        let systemPlugin3 = viewStorage.insertNewObject(ofType: SystemPlugin.self)
-        systemPlugin3.name = "Plugin 3"
-        systemPlugin3.siteID = sampleSiteID
-
-        let store = SystemStatusStore(dispatcher: dispatcher, storageManager: storageManager, network: network)
-
-        // When
-        let systemPluginResult: Yosemite.SystemPlugin? = waitFor { promise in
-            let action = SystemStatusAction.fetchSystemPluginListWithNameList(siteID: self.sampleSiteID,
-                                                                              systemPluginNameList: ["Plugin 2", "Plugin 3"]) { result in
-                promise(result)
-            }
-            store.onAction(action)
-        }
-
-        // Then
-        XCTAssertEqual(systemPluginResult?.name, "Plugin 3")
-    }
-
     func test_fetchSystemPluginWithPath_returns_plugin_when_matching_plugin_is_in_storage() {
         // Given
         let systemPlugin1 = viewStorage.insertNewObject(ofType: SystemPlugin.self)

WooCommerce/WooCommerceTests/ViewRelated/OrderDetailsViewModelTests.swift

@@ -727,8 +727,6 @@ private extension OrderDetailsViewModelTests {
             switch action {
             case let .fetchSystemPlugin(_, _, onCompletion):
                 onCompletion(plugin)
-            case let .fetchSystemPluginListWithNameList(_, _, onCompletion):
-                onCompletion(plugin)
             case let .fetchSystemPluginWithPath(_, pluginPath, onCompletion):
                 if let path, path != pluginPath {
                     onCompletion(nil)

WooCommerce/WooCommerceTests/ViewRelated/Orders/Order Details/OrderDetailsViewControllerTests.swift

@@ -190,16 +190,6 @@ private struct OrderDetailStoreManagerFactory {
             }
         }
 
-        // Need to sync plugins first
-        storesManager.whenReceivingAction(ofType: SystemStatusAction.self) { action in
-            switch action {
-            case let .fetchSystemPluginListWithNameList(_, _, onCompletion):
-                onCompletion(nil)
-            default:
-                break
-            }
-        }
-
         storesManager.whenReceivingAction(ofType: SubscriptionAction.self) { action in
             switch action {
             case let .loadSubscriptions(_, onCompletion):