Skip to content

Commit 6f550b8

Browse files
committed
Rename MockAnalytics to MockPOSAnalytics and update tests
Renamed MockAnalytics.swift to MockPOSAnalytics.swift and updated references in the Xcode project and test files. Added stub analytics tracking methods to MockPOSOrderListFetchStrategy implementations to support new analytics requirements in POSOrderListControllerTests.
1 parent 0a158df commit 6f550b8

File tree

4 files changed

+14
-5
lines changed

4 files changed

+14
-5
lines changed

WooCommerce/WooCommerce.xcodeproj/project.pbxproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@
113113
01AAD8142D92E37A0081D60B /* PointOfSaleOrderSyncCouponsErrorMessageView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 01AAD8132D92E37A0081D60B /* PointOfSaleOrderSyncCouponsErrorMessageView.swift */; };
114114
01AB2D122DDC7AD300AA67FD /* PointOfSaleItemListAnalyticsTrackerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 01AB2D112DDC7AD100AA67FD /* PointOfSaleItemListAnalyticsTrackerTests.swift */; };
115115
01AB2D142DDC7CD200AA67FD /* POSItemActionHandlerFactoryTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 01AB2D132DDC7CD000AA67FD /* POSItemActionHandlerFactoryTests.swift */; };
116-
01AB2D162DDC8CDA00AA67FD /* MockAnalytics.swift in Sources */ = {isa = PBXBuildFile; fileRef = 01AB2D152DDC8CD600AA67FD /* MockAnalytics.swift */; };
116+
01AB2D162DDC8CDA00AA67FD /* MockPOSAnalytics.swift in Sources */ = {isa = PBXBuildFile; fileRef = 01AB2D152DDC8CD600AA67FD /* MockPOSAnalytics.swift */; };
117117
01ABA0282E57579300829DC0 /* POSOrderListView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 01ABA0252E57579300829DC0 /* POSOrderListView.swift */; };
118118
01ABA0292E57579300829DC0 /* POSDetailsView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 01ABA0242E57579300829DC0 /* POSDetailsView.swift */; };
119119
01ABA02A2E57579300829DC0 /* POSOrdersView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 01ABA0262E57579300829DC0 /* POSOrdersView.swift */; };
@@ -3330,7 +3330,7 @@
33303330
01AAD8132D92E37A0081D60B /* PointOfSaleOrderSyncCouponsErrorMessageView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PointOfSaleOrderSyncCouponsErrorMessageView.swift; sourceTree = "<group>"; };
33313331
01AB2D112DDC7AD100AA67FD /* PointOfSaleItemListAnalyticsTrackerTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PointOfSaleItemListAnalyticsTrackerTests.swift; sourceTree = "<group>"; };
33323332
01AB2D132DDC7CD000AA67FD /* POSItemActionHandlerFactoryTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = POSItemActionHandlerFactoryTests.swift; sourceTree = "<group>"; };
3333-
01AB2D152DDC8CD600AA67FD /* MockAnalytics.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockAnalytics.swift; sourceTree = "<group>"; };
3333+
01AB2D152DDC8CD600AA67FD /* MockPOSAnalytics.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockPOSAnalytics.swift; sourceTree = "<group>"; };
33343334
01ABA0242E57579300829DC0 /* POSDetailsView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = POSDetailsView.swift; sourceTree = "<group>"; };
33353335
01ABA0252E57579300829DC0 /* POSOrderListView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = POSOrderListView.swift; sourceTree = "<group>"; };
33363336
01ABA0262E57579300829DC0 /* POSOrdersView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = POSOrdersView.swift; sourceTree = "<group>"; };
@@ -7868,7 +7868,7 @@
78687868
012ACB812E5D8DCD00A49458 /* MockPOSOrderListFetchStrategyFactory.swift */,
78697869
012ACB792E5C84D200A49458 /* MockPOSOrderListService.swift */,
78707870
01F935582DFC0D4800B50B03 /* MockPointOfSaleSoundPlayer.swift */,
7871-
01AB2D152DDC8CD600AA67FD /* MockAnalytics.swift */,
7871+
01AB2D152DDC8CD600AA67FD /* MockPOSAnalytics.swift */,
78727872
686A71B72DC9EB6D0006E835 /* MockPOSSearchHistoryService.swift */,
78737873
2050D2652DF07BF700C25211 /* MockPointOfSaleBarcodeScanService.swift */,
78747874
01A3093B2DAE768000B672F6 /* MockPointOfSaleCouponService.swift */,
@@ -17208,7 +17208,7 @@
1720817208
CC33238C29CDF67D00CA9709 /* ComponentSettingsViewModelTests.swift in Sources */,
1720917209
026878D82E2942E400DBFD34 /* PointOfSaleDashboardViewHelperTests.swift in Sources */,
1721017210
86F5FFE42CA30D9200C767C4 /* CustomFieldsListViewModelTests.swift in Sources */,
17211-
01AB2D162DDC8CDA00AA67FD /* MockAnalytics.swift in Sources */,
17211+
01AB2D162DDC8CDA00AA67FD /* MockPOSAnalytics.swift in Sources */,
1721217212
0261F5A728D454CF00B7AC72 /* ProductSearchUICommandTests.swift in Sources */,
1721317213
098FFA1727AD7F5D002EBEE4 /* OrderStatusListDataSourceTests.swift in Sources */,
1721417214
DA24152B2D116EAE0008F69A /* WooShippingAddPackageViewModelTests.swift in Sources */,

WooCommerce/WooCommerceTests/POS/Controllers/POSOrderListControllerTests.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ import struct Yosemite.POSOrder
99
final class POSOrderListControllerTests {
1010
private let orderListService = MockPOSOrderListService()
1111
private lazy var fetchStrategyFactory = MockPOSOrderListFetchStrategyFactory(orderService: orderListService)
12-
private lazy var sut = POSOrderListController(orderListFetchStrategyFactory: fetchStrategyFactory)
12+
private lazy var sut = POSOrderListController(orderListFetchStrategyFactory: fetchStrategyFactory,
13+
analytics: MockPOSAnalytics())
1314

1415
@Test func loadOrders_requests_first_page_after_loading_two_pages() async throws {
1516
try #require(sut.ordersViewState.isLoading)

WooCommerce/WooCommerceTests/POS/Mocks/MockPOSOrderListFetchStrategyFactory.swift

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ private struct MockPOSOrderListFetchStrategy: POSOrderListFetchStrategy {
3636
func loadOrder(orderID: Int64) async throws -> Yosemite.POSOrder {
3737
try await orderService.loadOrder(orderID: orderID)
3838
}
39+
40+
func trackFetched(millisecondsSinceRequestSent: Int) {}
41+
42+
func trackNextPageLoaded(pageNumber: Int) {}
3943
}
4044

4145
private struct MockPOSOrderListSearchFetchStrategy: POSOrderListFetchStrategy {
@@ -53,4 +57,8 @@ private struct MockPOSOrderListSearchFetchStrategy: POSOrderListFetchStrategy {
5357
func loadOrder(orderID: Int64) async throws -> Yosemite.POSOrder {
5458
try await orderService.loadOrder(orderID: orderID)
5559
}
60+
61+
func trackFetched(millisecondsSinceRequestSent: Int) {}
62+
63+
func trackNextPageLoaded(pageNumber: Int) {}
5664
}

0 commit comments

Comments
 (0)