Introduce timezone parameter to the range description formatting

Author: ThomazFB

Networking/Networking/Extensions/DateFormatter+Woo.swift

@@ -107,31 +107,31 @@ public extension DateFormatter {
         /// Date formatter used for creating the properly-formatted date range info. Typically
         /// used when setting the end date on `AnalyticsHubTimeRangeGenerator`.
         ///
-        public static let analyticsHubDayMonthYearFormatter: DateFormatter = {
+        public static func createAnalyticsHubDayMonthYearFormatter(timezone: TimeZone) -> DateFormatter {
             let formatter = DateFormatter()
-            formatter.locale = Locale(identifier: "en_US_POSIX")
+            formatter.timeZone = timezone
             formatter.dateFormat = "MMM d, yyyy"
             return formatter
-        }()
+        }
 
         /// Date formatter used for creating the properly-formatted date range info. Typically
         /// used when setting the end date of a same-month range on `AnalyticsHubTimeRangeGenerator`.
         ///
-        public static let analyticsHubDayYearFormatter: DateFormatter = {
+        public static func createAnalyticsHubDayYearFormatter(timezone: TimeZone) -> DateFormatter {
             let formatter = DateFormatter()
-            formatter.locale = Locale(identifier: "en_US_POSIX")
+            formatter.timeZone = timezone
             formatter.dateFormat = "d, yyyy"
             return formatter
-        }()
+        }
 
         /// Date formatter used for creating the properly-formatted date range info. Typically
         /// used when setting the start date on `AnalyticsHubTimeRangeGenerator`.
         ///
-        public static let analyticsHubDayMonthFormatter: DateFormatter = {
+        public static func createAnalyticsHubDayMonthFormatter(timezone: TimeZone) -> DateFormatter {
             let formatter = DateFormatter()
-            formatter.locale = Locale(identifier: "en_US_POSIX")
+            formatter.timeZone = timezone
             formatter.dateFormat = "MMM d"
             return formatter
-        }()
+        }
     }
 }

WooCommerce/Classes/ViewRelated/Dashboard/Analytics Hub/Time Range/AnalyticsHubTimeRange.swift

@@ -4,17 +4,19 @@ struct AnalyticsHubTimeRange {
     let start: Date
     let end: Date
 
-    func formatToString(simplified: Bool, calendar: Calendar) -> String {
+    func formatToString(simplified: Bool, timezone: TimeZone, calendar: Calendar) -> String {
         if simplified {
-            return DateFormatter.Stats.analyticsHubDayMonthYearFormatter.string(from: start)
+            return DateFormatter.Stats.createAnalyticsHubDayMonthYearFormatter(timezone: timezone).string(from: start)
         }
 
-        let startDateDescription = DateFormatter.Stats.analyticsHubDayMonthFormatter.string(from: start)
+        let startDateDescription = DateFormatter.Stats.createAnalyticsHubDayMonthFormatter(timezone: timezone).string(from: start)
 
+        var endDateDescription: String
         if start.isSameMonth(as: end, using: calendar) {
-            return "\(startDateDescription) - \(DateFormatter.Stats.analyticsHubDayYearFormatter.string(from: end))"
+            endDateDescription = DateFormatter.Stats.createAnalyticsHubDayYearFormatter(timezone: timezone).string(from: end)
         } else {
-            return "\(startDateDescription) - \(DateFormatter.Stats.analyticsHubDayMonthYearFormatter.string(from: end))"
+            endDateDescription = DateFormatter.Stats.createAnalyticsHubDayMonthYearFormatter(timezone: timezone).string(from: end)
         }
+        return "\(startDateDescription) - \(endDateDescription)"
     }
 }

WooCommerce/Classes/ViewRelated/Dashboard/Analytics Hub/Time Range/AnalyticsHubTimeRangeSelection.swift

@@ -44,8 +44,10 @@ public class AnalyticsHubTimeRangeSelection {
         self.previousTimeRange = previousTimeRange
         self.rangeSelectionDescription = selectionType.description
         self.formattedCurrentRangeText = currentTimeRange?.formatToString(simplified: simplifiedDescription,
+                                                                          timezone: timezone,
                                                                           calendar: calendar)
         self.formattedPreviousRangeText = previousTimeRange?.formatToString(simplified: simplifiedDescription,
+                                                                            timezone: timezone,
                                                                             calendar: calendar)
     }