Skip to content

Commit 7504066

Browse files
authored
Merge pull request #8428 from woocommerce/issue/8324-release-sessions-card
[Analytics Hub] Release Sessions card and remove feature flag
2 parents d71c1cf + 411a4f8 commit 7504066

File tree

4 files changed

+2
-7
lines changed

4 files changed

+2
-7
lines changed

Experiments/Experiments/DefaultFeatureFlagService.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
5353
.performanceMonitoringUserInteraction:
5454
// Disabled by default to avoid costs spikes, unless in internal testing builds.
5555
return buildConfig == .alpha
56-
case .analyticsHub:
57-
return buildConfig == .localDeveloper || buildConfig == .alpha
5856
case .tapToPayOnIPhone:
5957
return buildConfig == .localDeveloper
6058
default:

Experiments/Experiments/FeatureFlag.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,4 @@ public enum FeatureFlag: Int {
133133
///
134134
/// - Note: The app will ignore this if `performanceMonitoring` is `false`.
135135
case performanceMonitoringViewController
136-
137-
/// Temporary feature flag for the native Jetpack setup flow.
138-
///
139-
case analyticsHub
140136
}

RELEASE-NOTES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
11.7
44
-----
55
- [**] Analytics Hub: Now you can select custom date ranges. [https://github.com/woocommerce/woocommerce-ios/pull/8414]
6+
- [**] Analytics Hub: Now you can see Views and Conversion Rate analytics in the new Sessions card. [https://github.com/woocommerce/woocommerce-ios/pull/8428]
67
- [*] My Store: We fixed an issue with Visitors and Conversion stats where sometimes visitors could be counted more than once in the selected period. [https://github.com/woocommerce/woocommerce-ios/pull/8427]
78

89

WooCommerce/Classes/ViewRelated/Dashboard/Analytics Hub/AnalyticsHubView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ struct AnalyticsHubView: View {
113113

114114
Divider()
115115
}
116-
.renderedIf(ServiceLocator.featureFlagService.isFeatureFlagEnabled(.analyticsHub) && viewModel.showSessionsCard)
116+
.renderedIf(viewModel.showSessionsCard)
117117

118118
Spacer()
119119
}

0 commit comments

Comments
 (0)