Skip to content

Commit 79dead8

Browse files
authored
[WCiOS17] Address some CardReader warnings (#15998)
2 parents 5a9f525 + 7516d5d commit 79dead8

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

Modules/Sources/Hardware/CardReader/StripeCardReader/PaymentMethod+Stripe.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ extension PaymentMethod {
2424
return
2525
}
2626
self = .interacPresent(details: CardPresentTransactionDetails(details: details))
27-
case .unknown:
27+
case .affirm, .wechatPay, .unknown:
2828
self = .unknown
2929
@unknown default:
3030
self = .unknown

RELEASE-NOTES.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
23.1
55
-----
6-
6+
- [*] Payments: Updated the In-Person Payments `Learn More` redirection to display the correct page based on the selected payment provider [https://github.com/woocommerce/woocommerce-ios/pull/15998]
77

88
23.0
99
-----

WooCommerce/Classes/ViewRelated/Dashboard/Settings/CardReadersV2/CardReaderSettingsSearchingViewModel.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ final class CardReaderSettingsSearchingViewModel: PaymentSettingsFlowPresentedVi
4343
self.knownReaderProvider = knownReaderProvider
4444
self.configuration = configuration
4545
self.cardReaderConnectionAnalyticsTracker = cardReaderConnectionAnalyticsTracker
46-
self.learnMoreURL = CardPresentPaymentsPlugin.wcPay.setUpTapToPayLearnMoreURL
46+
self.learnMoreURL = CardPresentPaymentsPlugin.wcPay.manageCardReaderLearnMoreURL
4747

4848
beginKnownReaderObservation()
4949
beginConnectedReaderObservation()
@@ -109,7 +109,7 @@ final class CardReaderSettingsSearchingViewModel: PaymentSettingsFlowPresentedVi
109109
private func updateLearnMoreUrl(stores: StoresManager) {
110110
let loadLearnMoreUrlAction = CardPresentPaymentAction
111111
.loadActivePaymentGatewayExtension() { [weak self] result in
112-
result.manageCardReaderLearnMoreURL
112+
self?.learnMoreURL = result.manageCardReaderLearnMoreURL
113113
}
114114
stores.dispatch(loadLearnMoreUrlAction)
115115
}

0 commit comments

Comments
 (0)