simplify salesChannel property accessor

Author: iamgabrielma

WooCommerce/Classes/ViewRelated/Orders/Order Details/Order Summary Section/SummaryTableViewCell.swift

@@ -31,7 +31,7 @@ final class SummaryTableViewCell: UITableViewCell {
     func configure(_ viewModel: SummaryTableViewCellViewModel) {
         titleLabel.text = viewModel.billedPersonName
         subtitleLabel.text = viewModel.subtitle
-        salesChannelLabel.text = viewModel.formattedSalesChannel
+        salesChannelLabel.text = viewModel.salesChannel
         salesChannelLabel.isHidden = (salesChannelLabel.text == nil)
         display(presentation: viewModel.presentation)
     }

WooCommerce/Classes/ViewRelated/Orders/Order Details/Order Summary Section/SummaryTableViewCellViewModel.swift

@@ -9,21 +9,19 @@ struct SummaryTableViewCellViewModel {
 
     private let billingAddress: Address?
     private let dateCreated: Date
-    private let salesChannel: String?
+    private(set) var salesChannel: String?
 
     let presentation: OrderStatusPresentation
 
     private let calendar: Calendar
-    private let order: Order
 
     init(order: Order,
          status: OrderStatus?,
          calendar: Calendar = .current) {
-        self.order = order
 
         billingAddress = order.billingAddress
         dateCreated = order.dateCreated
-        salesChannel = order.createdVia
+        salesChannel = order.salesChannel?.description
 
         presentation = OrderStatusPresentation(
             style: status?.status ?? order.status,
@@ -50,12 +48,6 @@ struct SummaryTableViewCellViewModel {
         formatter.timeZone = .siteTimezone
         return formatter.string(from: dateCreated)
     }
-
-    /// Textual representation of the sales channel
-    ///
-    var formattedSalesChannel: String? {
-        order.salesChannel?.description
-    }
 }
 
 private extension SummaryTableViewCellViewModel {