[POS as a tab i1] Analytics and enable local feature flag for public release (#15766)

Author: jaclync

Modules/Sources/Experiments/DefaultFeatureFlagService.swift

@@ -109,7 +109,7 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
             // Enables a simulated barcode scanner in dev builds for testing. Do not ship this one!
             return buildConfig == .localDeveloper || buildConfig == .alpha
         case .pointOfSaleAsATabi1:
-            return buildConfig == .localDeveloper || buildConfig == .alpha
+            return true
         default:
             return true
         }

RELEASE-NOTES.txt

@@ -3,7 +3,7 @@
 
 22.7
 -----
-
+- [**] POS: a POS tab in the tab bar is now available in the app for stores eligible for Point of Sale, instead of the previous entry point in the Menu tab. [https://github.com/woocommerce/woocommerce-ios/pull/15766]
 
 22.6
 -----

WooCommerce/Classes/Analytics/WooAnalyticsStat.swift

@@ -1276,6 +1276,8 @@ enum WooAnalyticsStat: String {
     case backgroundUpdatesDisabled = "background_updates_disabled"
 
     // MARK: Point of Sale events
+    case pointOfSaleTabSelected = "main_tab_pos_selected"
+    case pointOfSaleTabVisibilityChecked = "pos_tab_visibility_checked"
     case pointOfSaleLoaded = "loaded"
     case pointOfSaleItemsFetched = "items_fetched"
     case pointOfSaleItemsPullToRefresh = "items_pull_to_refresh"

WooCommerce/Classes/ViewRelated/MainTabBarController.swift

@@ -352,7 +352,7 @@ private extension MainTabBarController {
         case .hubMenu:
             ServiceLocator.analytics.track(.hubMenuTabSelected)
         case .pointOfSale:
-            // TODO: WOOMOB-571 - analytics
+            ServiceLocator.analytics.track(.pointOfSaleTabSelected)
             break
         }
     }
@@ -373,7 +373,7 @@ private extension MainTabBarController {
             ServiceLocator.analytics.track(.hubMenuTabReselected)
             break
         case .pointOfSale:
-            // TODO: WOOMOB-571 - analytics
+            assertionFailure("Point of Sale tab should not be reselected as it cannot be selected from `tabBarController(_:shouldSelect:)`.")
             break
         }
     }
@@ -672,6 +672,7 @@ private extension MainTabBarController {
             guard let self, let posEligibilityChecker = self.posEligibilityChecker else { return }
             let eligibility = await posEligibilityChecker.checkEligibility()
             let isPOSTabVisible = eligibility == .eligible
+            analytics.track(.pointOfSaleTabVisibilityChecked, withProperties: ["is_visible": isPOSTabVisible])
             cachePOSTabVisibility(siteID: siteID, isPOSTabVisible: isPOSTabVisible)
             updateTabViewControllers(isPOSTabVisible: isPOSTabVisible)
             viewModel.loadHubMenuTabBadge()

WooCommerce/WooCommerceTests/ViewRelated/MainTabBarControllerTests.swift

@@ -560,6 +560,41 @@ final class MainTabBarControllerTests: XCTestCase {
         // Then
         XCTAssertEqual(mockPOSEligibilityService.loadCachedPOSTabVisibility(siteID: 1216), true)
     }
+
+    func test_event_is_tracked_after_eligibility_check() throws {
+        // Given
+        let featureFlagService = MockFeatureFlagService()
+        featureFlagService.isFeatureFlagEnabledReturnValue[.pointOfSaleAsATabi1] = true
+
+        let mockPOSEligibilityChecker = MockPOSEligibilityChecker()
+        mockPOSEligibilityChecker.result = .eligible
+
+        let storesManager = MockStoresManager(sessionManager: .makeForTesting())
+
+        guard let tabBarController = UIStoryboard(name: "Main", bundle: nil).instantiateInitialViewController(creator: { coder in
+            return MainTabBarController(coder: coder,
+                                        featureFlagService: featureFlagService,
+                                        analytics: self.analytics,
+                                        stores: storesManager,
+                                        posEligibilityCheckerFactory: { _ in mockPOSEligibilityChecker })
+        }) else {
+            return
+        }
+
+        // Trigger `viewDidLoad`
+        XCTAssertNotNil(tabBarController.view)
+
+        // When
+        storesManager.updateDefaultStore(storeID: 322)
+
+        // Then
+        waitUntil {
+            tabBarController.tabRootViewControllers.count == 5
+        }
+
+        let indexOfEvent = try XCTUnwrap(analyticsProvider.receivedEvents.firstIndex(of: WooAnalyticsStat.pointOfSaleTabVisibilityChecked.rawValue))
+        assertEqual(true, analyticsProvider.receivedProperties[safe: indexOfEvent]?["is_visible"] as? Bool)
+    }
 }
 
 extension MainTabBarController {