Remove unnecessary await calls

joshheald · staskus · web-flow · commit 8136676649c5 · 2025-10-22T09:38:15.000+01:00
Co-authored-by: Povilas Staskus &lt;povilas.staskus@automattic.com&gt;
diff --git a/Modules/Sources/Yosemite/PointOfSale/Items/PointOfSaleLocalBarcodeScanService.swift b/Modules/Sources/Yosemite/PointOfSale/Items/PointOfSaleLocalBarcodeScanService.swift
@@ -27,7 +27,7 @@ public final class PointOfSaleLocalBarcodeScanService: PointOfSaleBarcodeScanSer
             }
 
             if let variationAndParent = try searchVariationByGlobalUniqueID(barcode) {
-                return try await convertVariationToItem(variationAndParent.variation, parentProduct: variationAndParent.parentProduct, scannedCode: barcode)
+                return try convertVariationToItem(variationAndParent.variation, parentProduct: variationAndParent.parentProduct, scannedCode: barcode)
             }
 
             throw PointOfSaleBarcodeScanError.notFound(scannedCode: barcode)
@@ -97,7 +97,7 @@ public final class PointOfSaleLocalBarcodeScanService: PointOfSaleBarcodeScanSer
 
     private func convertVariationToItem(_ persistedVariation: PersistedProductVariation,
                                         parentProduct: PersistedProduct,
-                                        scannedCode: String) async throws(PointOfSaleBarcodeScanError) -> POSItem {
+                                        scannedCode: String) throws(PointOfSaleBarcodeScanError) -> POSItem {
         do {
             // Convert both variation and parent to POS models
             let posVariation = try persistedVariation.toPOSProductVariation(db: grdbManager.databaseConnection)

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public final class PointOfSaleLocalBarcodeScanService: PointOfSaleBarcodeScanSer`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`if let variationAndParent = try searchVariationByGlobalUniqueID(barcode) {`
`30`		`- return try await convertVariationToItem(variationAndParent.variation, parentProduct: variationAndParent.parentProduct, scannedCode: barcode)`
	`30`	`+ return try convertVariationToItem(variationAndParent.variation, parentProduct: variationAndParent.parentProduct, scannedCode: barcode)`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`throw PointOfSaleBarcodeScanError.notFound(scannedCode: barcode)`
`@@ -97,7 +97,7 @@ public final class PointOfSaleLocalBarcodeScanService: PointOfSaleBarcodeScanSer`
`97`	`97`
`98`	`98`	`private func convertVariationToItem(_ persistedVariation: PersistedProductVariation,`
`99`	`99`	`parentProduct: PersistedProduct,`
`100`		`- scannedCode: String) async throws(PointOfSaleBarcodeScanError) -> POSItem {`
	`100`	`+ scannedCode: String) throws(PointOfSaleBarcodeScanError) -> POSItem {`
`101`	`101`	`do {`
`102`	`102`	`// Convert both variation and parent to POS models`
`103`	`103`	`let posVariation = try persistedVariation.toPOSProductVariation(db: grdbManager.databaseConnection)`