Rename Notice property and update documentation

Author: rachelmcr

WooCommerce/Classes/ViewRelated/Dashboard/Analytics Hub/AnalyticsHubView.swift

@@ -110,7 +110,7 @@ struct AnalyticsHubView: View {
         .task {
             await viewModel.updateData()
         }
-        .onReceive(viewModel.$notice) { notice in
+        .onReceive(viewModel.$dismissNotice) { notice in
             guard let notice else { return }
             dismissWithNotice(notice)
         }

WooCommerce/Classes/ViewRelated/Dashboard/Analytics Hub/AnalyticsHubViewModel.swift

@@ -47,10 +47,10 @@ final class AnalyticsHubViewModel: ObservableObject {
     ///
     @Published var timeRangeCard: AnalyticsTimeRangeCardViewModel
 
-    /// Defines a notice that should be shown after the view is dismissed.
+    /// Defines a notice that, when set, dismisses the view and is then displayed.
     /// Defaults to `nil`.
     ///
-    @Published var notice: Notice?
+    @Published var dismissNotice: Notice?
 
     // MARK: Private data
 
@@ -77,7 +77,7 @@ final class AnalyticsHubViewModel: ObservableObject {
         do {
             try await retrieveOrderStats()
         } catch is AnalyticsHubTimeRangeSelection.TimeRangeGeneratorError {
-            notice = Notice(title: Localization.timeRangeGeneratorError, feedbackType: .error)
+            dismissNotice = Notice(title: Localization.timeRangeGeneratorError, feedbackType: .error)
             DDLogWarn("⚠️ Error selecting analytics time range: \(timeRangeSelectionType.description)")
         } catch {
             switchToErrorState()