Mark necessary code as public in preparation for the move to POS module.

jaclync · jaclync · commit 827f23edaa74 · 2025-09-25T16:22:30.000+08:00
diff --git a/Modules/Sources/Yosemite/Model/Model.swift b/Modules/Sources/Yosemite/Model/Model.swift
@@ -31,6 +31,7 @@ public typealias FallibleCancelable = Hardware.FallibleCancelable
 public typealias CommentStatus = Networking.CommentStatus
 public typealias CompositeComponentOptionType = Networking.CompositeComponentOptionType
 public typealias Coupon = Networking.Coupon
+public typealias CouponDiscountType = Networking.Coupon.DiscountType
 public typealias CouponReport = Networking.CouponReport
 public typealias Country = Networking.Country
 public typealias CreateAccountResult = Networking.CreateAccountResult
diff --git a/WooCommerce/Classes/POS/Analytics/POSCollectOrderPaymentAnalyticsTracking.swift b/WooCommerce/Classes/POS/Analytics/POSCollectOrderPaymentAnalyticsTracking.swift
@@ -1,4 +1,4 @@
-protocol POSCollectOrderPaymentAnalyticsTracking {
+public protocol POSCollectOrderPaymentAnalyticsTracking {
     func trackCustomerInteractionStarted()
     func trackOrderSyncSuccess()
     func trackCardReaderReady()
diff --git a/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentCardReader.swift b/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentCardReader.swift
@@ -1,6 +1,6 @@
 import Foundation
 
-struct CardPresentPaymentCardReader: Equatable {
+public struct CardPresentPaymentCardReader: Equatable {
     let name: String
 
     /// The reader's battery level, if available.
diff --git a/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentEvent.swift b/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentEvent.swift
@@ -1,6 +1,6 @@
 import Foundation
 
-enum CardPresentPaymentEvent {
+public enum CardPresentPaymentEvent {
     case idle
     case show(eventDetails: CardPresentPaymentEventDetails)
     case showOnboarding(factory: CardPresentPaymentOnboardingViewContainer, onCancel: () -> Void)
diff --git a/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentEventDetails.swift b/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentEventDetails.swift
@@ -1,7 +1,7 @@
 import Foundation
 import struct Yosemite.CardReaderInput
 
-enum CardPresentPaymentEventDetails {
+public enum CardPresentPaymentEventDetails {
     case scanningForReaders(endSearch: () -> Void)
     case scanningFailed(error: Error,
                         endSearch: () -> Void)
diff --git a/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentReaderConnectionResult.swift b/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentReaderConnectionResult.swift
@@ -1,6 +1,6 @@
 import Foundation
 
-enum CardPresentPaymentReaderConnectionResult {
+public enum CardPresentPaymentReaderConnectionResult {
     case connected(CardPresentPaymentCardReader)
     case canceled
 }
diff --git a/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentReaderConnectionStatus.swift b/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentReaderConnectionStatus.swift
@@ -1,6 +1,6 @@
 import Foundation
 
-enum CardPresentPaymentReaderConnectionStatus: Equatable {
+public enum CardPresentPaymentReaderConnectionStatus: Equatable {
     case disconnected
     case connected(CardPresentPaymentCardReader)
     case cancellingConnection
diff --git a/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentResult.swift b/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentResult.swift
@@ -1,6 +1,6 @@
 import Foundation
 
-enum CardPresentPaymentResult {
+public enum CardPresentPaymentResult {
     case success(CardPresentPaymentTransaction)
     case cancellation
 }
diff --git a/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentTransaction.swift b/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentTransaction.swift
@@ -1,6 +1,6 @@
 import Foundation
 
 /// A completed, paid transaction.
-struct CardPresentPaymentTransaction {
+public struct CardPresentPaymentTransaction {
     let receiptURL: URL
 }
diff --git a/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentsRetryApproach.swift b/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentsRetryApproach.swift
@@ -2,7 +2,7 @@ import Foundation
 import enum Yosemite.CardReaderServiceError
 import enum Yosemite.CardReaderServiceUnderlyingError
 
-enum CardPresentPaymentRetryApproach {
+public enum CardPresentPaymentRetryApproach {
     case dontRetry
     case tryAgain(retryAction: () -> Void)
     case tryAnotherPaymentMethod(retryAction: () -> Void)
diff --git a/WooCommerce/Classes/POS/Card Present Payments/CardReaderConnectionMethod.swift b/WooCommerce/Classes/POS/Card Present Payments/CardReaderConnectionMethod.swift
@@ -1,6 +1,6 @@
 import Foundation
 
-enum CardReaderConnectionMethod {
+public enum CardReaderConnectionMethod {
     case bluetooth
     case tapToPay
 }
diff --git a/WooCommerce/Classes/POS/Presentation/Payments Onboarding/PointOfSaleCardPresentPaymentOnboardingViewModel.swift b/WooCommerce/Classes/POS/Presentation/Payments Onboarding/PointOfSaleCardPresentPaymentOnboardingViewModel.swift
@@ -8,7 +8,7 @@ protocol CardPresentPaymentsOnboardingViewConfiguration: ObservableObject {
     var state: CardPresentPaymentOnboardingState { get }
 }
 
-final class CardPresentPaymentOnboardingViewContainer: ObservableObject, Equatable, Identifiable {
+public class CardPresentPaymentOnboardingViewContainer: ObservableObject, Equatable, Identifiable {
     @Published var configuration: any CardPresentPaymentsOnboardingViewConfiguration
     @Published var view: any View
 
@@ -17,7 +17,7 @@ final class CardPresentPaymentOnboardingViewContainer: ObservableObject, Equatab
         self.view = view
     }
 
-    static func == (lhs: CardPresentPaymentOnboardingViewContainer, rhs: CardPresentPaymentOnboardingViewContainer) -> Bool {
+    public static func == (lhs: CardPresentPaymentOnboardingViewContainer, rhs: CardPresentPaymentOnboardingViewContainer) -> Bool {
         lhs.configuration.state == rhs.configuration.state
     }
 }
diff --git a/WooCommerce/Classes/POS/Protocols/POSDependencyProviding.swift b/WooCommerce/Classes/POS/Protocols/POSDependencyProviding.swift
@@ -3,16 +3,17 @@ import WooFoundationCore
 import WooFoundation
 import enum Experiments.FeatureFlag
 import struct Yosemite.Coupon
+import enum Yosemite.CouponDiscountType
 import enum Yosemite.POSItem
 
 /// POSDepenencyProviding is part of the POS entry point that defines the external dependencies from the Woo app that POS depends on
 
 /// Protocol that provides analytics tracking capabilities for POS
-protocol POSAnalyticsProviding {
-    func track(event: WooAnalyticsEvent)
-    func track(_ stat: WooAnalyticsStat)
-    func track(_ stat: WooAnalyticsStat, parameters: [String: WooAnalyticsEventPropertyType])
-    func track(_ stat: WooAnalyticsStat, parameters: [String: WooAnalyticsEventPropertyType], error: Error)
+public protocol POSAnalyticsProviding {
+    func track(event: WooFoundationCore.WooAnalyticsEvent)
+    func track(_ stat: WooFoundationCore.WooAnalyticsStat)
+    func track(_ stat: WooFoundationCore.WooAnalyticsStat, parameters: [String: WooAnalyticsEventPropertyType])
+    func track(_ stat: WooFoundationCore.WooAnalyticsStat, parameters: [String: WooAnalyticsEventPropertyType], error: Error)
 }
 
 extension POSAnalyticsProviding {
@@ -22,48 +23,48 @@ extension POSAnalyticsProviding {
 }
 
 /// Protocol that provides currency settings access for POS
-protocol POSCurrencySettingsProviding {
+public protocol POSCurrencySettingsProviding {
     var currencySettings: CurrencySettings { get }
 }
 
 /// Protocol that provides feature flag checking capabilities for POS
-protocol POSFeatureFlagProviding {
+public protocol POSFeatureFlagProviding {
     func isFeatureFlagEnabled(_ flag: FeatureFlag) -> Bool
 }
 
 /// Protocol that provides connectivity monitoring for POS
-protocol POSConnectivityProviding {
+public protocol POSConnectivityProviding {
     var connectivityObserver: ConnectivityObserver { get }
 }
 
 /// Protocol that provides main app navigation capabilities for POS
-protocol POSExternalNavigationProviding {
+public protocol POSExternalNavigationProviding {
     func navigateToCreateOrder()
 }
 
 /// Protocol that provides access to complex Woo application views that depend on a lot of Woo app target dependencies
 /// and cannot be easily moved and reused in a shared module
 /// This is used as a workaround to enable POS modularization without requiring a larger refactoring effort
 ///
-protocol POSExternalViewProviding {
+public protocol POSExternalViewProviding {
     func createSupportFormView(isPresented: Binding<Bool>, sourceTag: String) -> AnyView
     func createFormattableAmountTextField(preset: Decimal?,
                                           onSubmit: @escaping () -> Void,
                                           onChange: @escaping (String) -> Void) -> AnyView
-    func createCouponCreationView(discountType: Coupon.DiscountType,
+    func createCouponCreationView(discountType: CouponDiscountType,
                                   showTypeSelection: Binding<Bool>,
                                   onSuccess: @escaping (Coupon) -> Void,
                                   dismissHandler: @escaping () -> Void,
                                   onDisappear: @escaping () -> Void) -> AnyView
     func createDiscountTypeSelectionSheet(isPresented: Binding<Bool>,
                                           title: String,
                                           cancelButtonTitle: String,
-                                          onSelection: @escaping (Coupon.DiscountType) -> Void) -> AnyView
+                                          onSelection: @escaping (CouponDiscountType) -> Void) -> AnyView
 }
 
 /// Main protocol that combines all POS dependency providers
 /// This enables dependency injection for POS code while maintaining clean separation from ServiceLocator
-protocol POSDependencyProviding {
+public protocol POSDependencyProviding {
     var analytics: POSAnalyticsProviding { get }
     var currency: POSCurrencySettingsProviding { get }
     var featureFlags: POSFeatureFlagProviding { get }
diff --git a/WooCommerce/Classes/Tools/Binding.swift b/WooCommerce/Classes/Tools/Binding.swift
@@ -3,4 +3,4 @@ import struct SwiftUI.Binding
 /// `Binding` resides inside `SwiftUI`.
 /// This alias allows us to use it inside view models to communicate with `SwiftUI` views without having the import the module on each file.
 ///
-typealias Binding = SwiftUI.Binding
+public typealias Binding = SwiftUI.Binding

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-protocol POSCollectOrderPaymentAnalyticsTracking {`
	`1`	`+public protocol POSCollectOrderPaymentAnalyticsTracking {`
`2`	`2`	`func trackCustomerInteractionStarted()`
`3`	`3`	`func trackOrderSyncSuccess()`
`4`	`4`	`func trackCardReaderReady()`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`import Foundation`
`2`	`2`
`3`		`-enum CardPresentPaymentReaderConnectionResult {`
	`3`	`+public enum CardPresentPaymentReaderConnectionResult {`
`4`	`4`	`case connected(CardPresentPaymentCardReader)`
`5`	`5`	`case canceled`
`6`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`import Foundation`
`2`	`2`
`3`		`-enum CardPresentPaymentResult {`
	`3`	`+public enum CardPresentPaymentResult {`
`4`	`4`	`case success(CardPresentPaymentTransaction)`
`5`	`5`	`case cancellation`
`6`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`import Foundation`
`2`	`2`
`3`	`3`	`/// A completed, paid transaction.`
`4`		`-struct CardPresentPaymentTransaction {`
	`4`	`+public struct CardPresentPaymentTransaction {`
`5`	`5`	`let receiptURL: URL`
`6`	`6`	`}`