Remove retain cycle from MockTimeProvider

staskus · staskus · commit 83a5560e8e52 · 2025-08-04T10:04:22.000+02:00
diff --git a/WooCommerce/WooCommerceTests/POS/Presentation/Barcode Scanning/MockTimeProvider.swift b/WooCommerce/WooCommerceTests/POS/Presentation/Barcode Scanning/MockTimeProvider.swift
@@ -3,7 +3,7 @@ import Foundation
 
 final class MockTimer: Timer {
     var isCancelled = false
-    let mockTimeProvider: MockTimeProvider
+    weak var mockTimeProvider: MockTimeProvider?
     let timerInterval: TimeInterval
     let target: Any
     let selector: Selector
@@ -20,7 +20,7 @@ final class MockTimer: Timer {
 
     override func invalidate() {
         isCancelled = true
-        mockTimeProvider.removeTimer(self)
+        mockTimeProvider?.removeTimer(self)
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ import Foundation`
`3`	`3`
`4`	`4`	`final class MockTimer: Timer {`
`5`	`5`	`var isCancelled = false`
`6`		`- let mockTimeProvider: MockTimeProvider`
	`6`	`+ weak var mockTimeProvider: MockTimeProvider?`
`7`	`7`	`let timerInterval: TimeInterval`
`8`	`8`	`let target: Any`
`9`	`9`	`let selector: Selector`
`@@ -20,7 +20,7 @@ final class MockTimer: Timer {`
`20`	`20`
`21`	`21`	`override func invalidate() {`
`22`	`22`	`isCancelled = true`
`23`		`- mockTimeProvider.removeTimer(self)`
	`23`	`+ mockTimeProvider?.removeTimer(self)`
`24`	`24`	`}`
`25`	`25`	`}`
`26`	`26`