Add fallback when variation weight is a number

Author: rachelmcr

Networking/Networking/Model/Product/ProductVariation.swift

@@ -275,7 +275,12 @@ public struct ProductVariation: Codable, GeneratedCopiable, Equatable, Generated
         let backordersKey = try container.decode(String.self, forKey: .backordersKey)
         let backordersAllowed = try container.decode(Bool.self, forKey: .backordersAllowed)
         let backordered = try container.decode(Bool.self, forKey: .backordered)
-        let weight = try container.decodeIfPresent(String.self, forKey: .weight)
+
+        // Even though a plain install of WooCommerce Core provides String values,
+        // some plugins alter the field value from String to Int or Decimal.
+        let weight = container.failsafeDecodeIfPresent(targetType: String.self,
+                                                       forKey: .weight,
+                                                       alternativeTypes: [.decimal(transform: { NSDecimalNumber(decimal: $0).stringValue })])
         let dimensions = try container.decode(ProductDimensions.self, forKey: .dimensions)
         let shippingClass = try container.decodeIfPresent(String.self, forKey: .shippingClass)
         let shippingClassID = try container.decode(Int64.self, forKey: .shippingClassID)

Networking/NetworkingTests/Mapper/ProductVariationMapperTests.swift

@@ -41,6 +41,7 @@ final class ProductVariationMapperTests: XCTestCase {
         XCTAssertTrue(productVariation.purchasable)
         XCTAssertEqual(productVariation.permalink, "")
         XCTAssertEqual(productVariation.sku, "12345")
+        XCTAssertEqual(productVariation.weight, "2.5")
     }
 
     /// Test that the fields for variations of a subscription product are properly parsed.

Networking/NetworkingTests/Responses/product-variation-alternative-types.json

@@ -32,7 +32,7 @@
             "backorders": "notify",
             "backorders_allowed": true,
             "backordered": false,
-            "weight": "2.5",
+            "weight": 2.5,
             "dimensions": {
                 "length": "10",
                 "width": "2.5",