Don't store summary stats fetched in the Analytics Hub

Author: rachelmcr

WooCommerce/Classes/ViewRelated/Dashboard/Analytics Hub/AnalyticsHubViewModel.swift

@@ -215,7 +215,8 @@ private extension AnalyticsHubViewModel {
             let action = StatsActionV4.retrieveSiteSummaryStats(siteID: siteID,
                                                                 period: period,
                                                                 quantity: timeRangeSelectionType.quantity,
-                                                                latestDateToInclude: latestDateToInclude) { result in
+                                                                latestDateToInclude: latestDateToInclude,
+                                                                saveInStorage: false) { result in
                 continuation.resume(with: result)
             }
             stores.dispatch(action)

WooCommerce/WooCommerceTests/ViewRelated/Dashboard/Analytics Hub/AnalyticsHubViewModelTests.swift

@@ -26,7 +26,7 @@ final class AnalyticsHubViewModelTests: XCTestCase {
             case let .retrieveTopEarnerStats(_, _, _, _, _, _, _, completion):
                 let topEarners = TopEarnerStats.fake().copy(items: [.fake()])
                 completion(.success(topEarners))
-            case let .retrieveSiteSummaryStats(_, _, _, _, completion):
+            case let .retrieveSiteSummaryStats(_, _, _, _, _, completion):
                 let siteStats = SiteSummaryStats.fake().copy(visitors: 30, views: 53)
                 completion(.success(siteStats))
             default:
@@ -61,7 +61,7 @@ final class AnalyticsHubViewModelTests: XCTestCase {
                 completion(.failure(NSError(domain: "Test", code: 1)))
             case let .retrieveTopEarnerStats(_, _, _, _, _, _, _, completion):
                 completion(.failure(NSError(domain: "Test", code: 1)))
-            case let .retrieveSiteSummaryStats(_, _, _, _, completion):
+            case let .retrieveSiteSummaryStats(_, _, _, _, _, completion):
                 completion(.failure(NSError(domain: "Test", code: 1)))
             default:
                 break
@@ -99,7 +99,7 @@ final class AnalyticsHubViewModelTests: XCTestCase {
             case let .retrieveTopEarnerStats(_, _, _, _, _, _, _, completion):
                 let topEarners = TopEarnerStats.fake().copy(items: [.fake()])
                 completion(.success(topEarners))
-            case let .retrieveSiteSummaryStats(_, _, _, _, completion):
+            case let .retrieveSiteSummaryStats(_, _, _, _, _, completion):
                 let siteStats = SiteSummaryStats.fake()
                 loadingSessionsCard = vm.sessionsCard
                 completion(.success(siteStats))