Merge pull request #148 from woocommerce/issue/updating-authenticator-api

WordPressAuthenticator: Wiring the latest Delegate's API

Author: jleandroperez

Podfile

@@ -18,7 +18,7 @@ target 'WooCommerce' do
   #
   pod 'Automattic-Tracks-iOS', :git => 'https://github.com/Automattic/Automattic-Tracks-iOS.git', :tag => '0.2.3'
   pod 'Gridicons', '0.15'
-  pod 'WordPressAuthenticator', '~> 1.0'
+  pod 'WordPressAuthenticator', '1.0.2'
 
 
   # External Libraries

Podfile.lock

@@ -38,7 +38,7 @@ PODS:
   - Reachability (3.2)
   - SVProgressHUD (2.2.5)
   - UIDeviceIdentifier (0.5.0)
-  - WordPressAuthenticator (1.0.1):
+  - WordPressAuthenticator (1.0.2):
     - 1PasswordExtension (= 1.8.5)
     - Alamofire (= 4.7.2)
     - CocoaLumberjack (= 3.4.2)
@@ -72,7 +72,7 @@ DEPENDENCIES:
   - Crashlytics (~> 3.10)
   - Gridicons (= 0.15)
   - KeychainAccess (~> 3.1)
-  - WordPressAuthenticator (~> 1.0)
+  - WordPressAuthenticator (= 1.0.2)
 
 SPEC REPOS:
   https://github.com/cocoapods/specs.git:
@@ -126,12 +126,12 @@ SPEC CHECKSUMS:
   Reachability: 33e18b67625424e47b6cde6d202dce689ad7af96
   SVProgressHUD: 1428aafac632c1f86f62aa4243ec12008d7a51d6
   UIDeviceIdentifier: a959a6d4f51036b4180dd31fb26483a820f1cc46
-  WordPressAuthenticator: 60c07bcfb6f1578afaf17621ae4393d688c2ede9
+  WordPressAuthenticator: 20e8eb9cb61bef82370658037bdf9ca24a54570a
   WordPressKit: a24baaa783c3a221f2d9a51c19318cbb27333373
   WordPressShared: 063e1e8b1a7aaf635abf17f091a2d235a068abdc
   WordPressUI: af141587ec444f9af753a00605bd0d3f14d8d8a3
   wpxmlrpc: bfc572f62ce7ee897f6f38b098d2ba08732ecef4
 
-PODFILE CHECKSUM: 60104ed4eaf82cee487f83818dceb80f392ce97f
+PODFILE CHECKSUM: cf5b7216652672de11a865ab3265c7b0c38117e2
 
 COCOAPODS: 1.5.3

WooCommerce/Classes/Authentication/AuthenticationManager.swift

@@ -167,14 +167,19 @@ extension AuthenticationManager: WordPressAuthenticatorDelegate {
 
     /// Synchronizes the specified WordPress Account.
     ///
-    func sync(credentials: WordPressCredentials, onCompletion: @escaping (Error?) -> Void) {
+    func sync(credentials: WordPressCredentials, onCompletion: @escaping () -> Void) {
         guard case let .wpcom(username, authToken, _, _) = credentials else {
             fatalError("Self Hosted sites are not supported. Please review the Authenticator settings!")
         }
 
+        // TODO: This is *temporary*. Already gone in a branch!!
+        let onCompletionWrapper = { (_ error: Error?) in
+            onCompletion()
+        }
+
         StoresManager.shared
             .authenticate(credentials: .init(username: username, authToken: authToken))
-            .synchronizeEntities(onCompletion: onCompletion)
+            .synchronizeEntities(onCompletion: onCompletionWrapper)
     }
 
     /// Tracks a given Analytics Event.