combine tap and type to enter text, assert product name

Author: jostnes

WooCommerce/UITestsFoundation/Screens/Products/ProductsScreen.swift

@@ -83,7 +83,6 @@ public final class ProductsScreen: ScreenObject {
 
     public func selectProductType(productType: String) throws -> SingleProductScreen {
         app.staticTexts[productType].tap()
-
         return try SingleProductScreen()
     }
 }

WooCommerce/UITestsFoundation/Screens/Products/SingleProductScreen.swift

@@ -32,8 +32,7 @@ public final class SingleProductScreen: ScreenObject {
     }
 
     public func addProductTitle(productTitle: String) throws -> Self {
-        app.cells["product-title"].tap()
-        app.cells["product-title"].typeText(productTitle)
+        app.cells["product-title"].enterText(text: productTitle)
         return self
     }
 
@@ -42,8 +41,9 @@ public final class SingleProductScreen: ScreenObject {
         return self
     }
 
-    public func verifyNewProductScreenLoaded() {
+    public func verifyNewProductScreenLoaded(productName: String) {
         XCTAssertTrue(app.buttons["save-product-button"].exists)
         XCTAssertTrue(app.staticTexts["TIP"].exists)
+        XCTAssertTrue(app.textViews[productName].exists)
     }
 }

WooCommerce/UITestsFoundation/XCTest+Extensions.swift

@@ -22,6 +22,11 @@ extension XCUIElement {
         self.tap()
         self.typeText(text)
     }
+
+    func enterText(text: String) -> Void {
+        self.tap()
+        self.typeText(text)
+    }
 }
 
 extension XCTestCase {

WooCommerce/WooCommerceUITests/Tests/ProductsTests.swift

@@ -5,7 +5,7 @@ final class ProductsTests: XCTestCase {
 
     let productTypes = [
         "physical": "Simple physical product",
-        "virtual": "Virtual physical product",
+        "virtual": "Simple virtual product",
         "variable": "Variable product",
         "grouped": "Grouped product",
         "external": "External product"
@@ -40,6 +40,6 @@ final class ProductsTests: XCTestCase {
             .selectProductType(productType: productTypes["physical"]!)
             .addProductTitle(productTitle: product.name)
             .publishProduct()
-            .verifyNewProductScreenLoaded()
+            .verifyNewProductScreenLoaded(productName: product.name)
     }
 }