Try fixing test failures by DI'ing the value for UIImagePickerController.isSourceTypeAvailable(.camera).

Author: jaclync

WooCommerce/Classes/ViewRelated/Products/ProductsListViewModel.swift

@@ -4,7 +4,7 @@ import Yosemite
 import Experiments
 
 protocol ProductsListViewModelProtocol {
-    func scanToUpdateInventoryButtonShouldBeVisible(completion: @escaping (Bool) -> (Void))
+    func scanToUpdateInventoryButtonShouldBeVisible(isCameraAvailable: Bool, completion: @escaping (Bool) -> (Void))
 }
 
 /// View model for `ProductsViewController`. Has stores logic related to Bulk Editing and Woo Subscriptions.
@@ -201,14 +201,14 @@ final class ProductListViewModel: ProductsListViewModelProtocol {
     // The feature breaks if the Square plugin is active, since modifies inventory management logic
     // If the plugin is active, we'll hide the inventory scanner button
     // More details: https://wp.me/pdfdoF-2Nq
-    func scanToUpdateInventoryButtonShouldBeVisible(completion: @escaping (Bool) -> (Void)) {
+    func scanToUpdateInventoryButtonShouldBeVisible(isCameraAvailable: Bool = UIImagePickerController.isSourceTypeAvailable(.camera),
+                                                    completion: @escaping (Bool) -> (Void)) {
         let isPluginActive = isPluginActive(.wooSquare)
         switch isPluginActive {
         case true:
             completion(false)
         case false:
-            guard featureFlagService.isFeatureFlagEnabled(.scanToUpdateInventory),
-                  UIImagePickerController.isSourceTypeAvailable(.camera) else {
+            guard featureFlagService.isFeatureFlagEnabled(.scanToUpdateInventory), isCameraAvailable else {
                 return completion(false)
             }
             // If all conditions are met, scan to update inventory should be visible:

WooCommerce/WooCommerceTests/Mocks/MockProductListViewModel.swift

@@ -11,7 +11,7 @@ final class MockProductListViewModel: ProductsListViewModelProtocol {
         self.featureFlagService = featureFlagService
     }
 
-    func scanToUpdateInventoryButtonShouldBeVisible(completion: @escaping (Bool) -> (Void)) {
+    func scanToUpdateInventoryButtonShouldBeVisible(isCameraAvailable: Bool = true, completion: @escaping (Bool) -> (Void)) {
         guard self.featureFlagService.isFeatureFlagEnabled(.scanToUpdateInventory) else {
             scanToUpdateInventoryShouldBeVisible = false
             return completion(false)

WooCommerce/WooCommerceTests/ViewRelated/Products/ProductListViewModelTests.swift

@@ -360,7 +360,7 @@ final class ProductListViewModelTests: XCTestCase {
 
         // When
         let result = waitFor { promise in
-            viewModel.scanToUpdateInventoryButtonShouldBeVisible { result in
+            viewModel.scanToUpdateInventoryButtonShouldBeVisible(isCameraAvailable: true) { result in
                 promise(result)
             }
         }
@@ -388,7 +388,7 @@ final class ProductListViewModelTests: XCTestCase {
 
         // When
         let result = waitFor { promise in
-            viewModel.scanToUpdateInventoryButtonShouldBeVisible { result in
+            viewModel.scanToUpdateInventoryButtonShouldBeVisible(isCameraAvailable: true) { result in
                 promise(result)
             }
         }
@@ -412,7 +412,7 @@ final class ProductListViewModelTests: XCTestCase {
 
         // When
         let result = waitFor { promise in
-            viewModel.scanToUpdateInventoryButtonShouldBeVisible { result in
+            viewModel.scanToUpdateInventoryButtonShouldBeVisible(isCameraAvailable: true) { result in
                 promise(result)
             }
         }