Fix tests for products onboarding eligibility check

Author: rachelmcr

Yosemite/YosemiteTests/Stores/ProductStoreTests.swift

@@ -1528,11 +1528,11 @@ final class ProductStoreTests: XCTestCase {
         XCTAssertTrue(finished)
     }
 
-    // MARK: - ProductAction.checkForProducts
+    // MARK: - ProductAction.checkProductsOnboardingEligibility
 
-    /// Verifies that ProductAction.checkForProducts returns true result when remote returns an array with a product ID.
+    /// Verifies that ProductAction.checkProductsOnboardingEligibility returns false result when remote returns an array with a product ID.
     ///
-    func test_checkForProducts_returns_expected_result_when_remote_returns_product() throws {
+    func test_checkProductsOnboardingEligibility_returns_expected_result_when_remote_returns_product() throws {
         // Given
         let productStore = ProductStore(dispatcher: dispatcher, storageManager: storageManager, network: network)
         network.simulateResponse(requestUrlSuffix: "products", filename: "products-ids-only")
@@ -1547,13 +1547,13 @@ final class ProductStoreTests: XCTestCase {
 
         // Then
         XCTAssertTrue(result.isSuccess)
-        let hasProducts = try XCTUnwrap(result.get())
-        XCTAssertTrue(hasProducts)
+        let isEligible = try XCTUnwrap(result.get())
+        XCTAssertFalse(isEligible)
     }
 
-    /// Verifies that ProductAction.checkForProducts returns true result when a product already exists in local storage.
+    /// Verifies that ProductAction.checkProductsOnboardingEligibility returns false result when a product already exists in local storage.
     ///
-    func test_checkForProducts_with_IDs_returns_expected_result_when_local_storage_has_product() throws {
+    func test_checkProductsOnboardingEligibility_with_IDs_returns_expected_result_when_local_storage_has_product() throws {
         // Given
         storageManager.insertSampleProduct(readOnlyProduct: Product.fake().copy(siteID: sampleSiteID))
         let productStore = ProductStore(dispatcher: dispatcher, storageManager: storageManager, network: network)
@@ -1568,13 +1568,13 @@ final class ProductStoreTests: XCTestCase {
 
         // Then
         XCTAssertTrue(result.isSuccess)
-        let hasProducts = try XCTUnwrap(result.get())
-        XCTAssertTrue(hasProducts)
+        let isEligible = try XCTUnwrap(result.get())
+        XCTAssertFalse(isEligible)
     }
 
-    /// Verifies that ProductAction.checkForProducts returns false result for an empty array.
+    /// Verifies that ProductAction.checkProductsOnboardingEligibility returns true result for an empty array.
     ///
-    func test_checkForProducts_returns_expected_result_when_remote_returns_empty_array() throws {
+    func test_checkProductsOnboardingEligibility_returns_expected_result_when_remote_returns_empty_array() throws {
         // Given
         let productStore = ProductStore(dispatcher: dispatcher, storageManager: storageManager, network: network)
         network.simulateResponse(requestUrlSuffix: "products", filename: "products-ids-only-empty")
@@ -1589,8 +1589,8 @@ final class ProductStoreTests: XCTestCase {
 
         // Then
         XCTAssertTrue(result.isSuccess)
-        let hasProducts = try XCTUnwrap(result.get())
-        XCTAssertFalse(hasProducts)
+        let isEligible = try XCTUnwrap(result.get())
+        XCTAssertTrue(isEligible)
     }
 }