Make products onboarding banner dismissible

Author: rachelmcr

Storage/Storage/Model/Feature Announcements/FeatureAnnouncementCampaign.swift

@@ -5,6 +5,7 @@ public enum FeatureAnnouncementCampaign: String, Codable, Equatable {
     case linkedProductsPromo = "linked_products_promo"
     case paymentsInMenuTabBarButton = "payments_menu_tabbar_button"
     case paymentsInHubMenuButton = "payments_hub_menu_button"
+    case productsOnboarding = "products_onboarding_first_product"
 
     /// Added for use in `test_setFeatureAnnouncementDismissed_with_another_campaign_previously_dismissed_keeps_values_for_both`
     /// This can be removed when we have a second campaign, which can be used in the above test instead.

WooCommerce/Classes/ViewModels/Feature Announcement Cards/ProductsOnboardingAnnouncementCardViewModel.swift

@@ -1,5 +1,6 @@
 import Foundation
 import UIKit
+import enum Yosemite.AppSettingsAction
 
 struct ProductsOnboardingAnnouncementCardViewModel: AnnouncementCardViewModelProtocol {
     var showDividers: Bool = true
@@ -27,6 +28,17 @@ struct ProductsOnboardingAnnouncementCardViewModel: AnnouncementCardViewModelPro
         onCTATapped?()
     }
 
+    // MARK: Dismiss button
+
+    /// Ensures the banner isn't shown again after the user manually dismisses it.
+    ///
+    func dontShowAgainTapped() {
+        let action = AppSettingsAction.setFeatureAnnouncementDismissed(campaign: .productsOnboarding,
+                                                                       remindLater: false,
+                                                                       onCompletion: nil)
+        ServiceLocator.stores.dispatch(action)
+    }
+
     // MARK: Dismiss confirmation alert (disabled)
 
     var showDismissConfirmation: Bool = false
@@ -35,10 +47,6 @@ struct ProductsOnboardingAnnouncementCardViewModel: AnnouncementCardViewModelPro
 
     var dismissAlertMessage: String = ""
 
-    func dontShowAgainTapped() {
-        // No-op
-    }
-
     func remindLaterTapped() {
         // No-op
     }

WooCommerce/Classes/ViewRelated/Dashboard/DashboardViewModel.swift

@@ -124,18 +124,14 @@ final class DashboardViewModel {
                 if isEligible {
                     ServiceLocator.analytics.track(event: .ProductsOnboarding.storeIsEligible())
 
-                    if ABTest.productsOnboardingBanner.variation == .treatment(nil) {
-                        let viewModel = ProductsOnboardingAnnouncementCardViewModel(onCTATapped: { [weak self] in
-                            self?.announcementViewModel = nil // Dismiss announcement
-                            MainTabBarController.presentAddProductFlow()
-                        })
-                        self?.announcementViewModel = viewModel
-                        // For now, products onboarding takes precedence over Just In Time Messages,
-                        // so we can stop if there is an onboarding announcement to display.
-                        // This should be revisited when either onboarding or JITMs are expanded. See:
-                        // pe5pgL-11B-p2
-                        return
-                    }
+                    self?.setProductsOnboardingBannerIfNeeded()
+                }
+
+                // For now, products onboarding takes precedence over Just In Time Messages,
+                // so we can stop if there is an onboarding announcement to display.
+                // This should be revisited when either onboarding or JITMs are expanded. See: pe5pgL-11B-p2
+                if self?.announcementViewModel is ProductsOnboardingAnnouncementCardViewModel {
+                    return
                 }
                 onCompletion()
             case .failure(let error):
@@ -146,6 +142,27 @@ final class DashboardViewModel {
         stores.dispatch(action)
     }
 
+    /// Sets the view model for the products onboarding banner if the user hasn't dismissed it before,
+    /// and if the user is part of the treatment group for the products onboarding A/B test.
+    ///
+    private func setProductsOnboardingBannerIfNeeded() {
+        guard ABTest.productsOnboardingBanner.variation == .treatment(nil) else {
+            return
+        }
+
+        let getVisibility = AppSettingsAction.getFeatureAnnouncementVisibility(campaign: .productsOnboarding) { [weak self] result in
+            guard let self else { return }
+            if case let .success(isVisible) = result, isVisible {
+                let viewModel = ProductsOnboardingAnnouncementCardViewModel(onCTATapped: { [weak self] in
+                    self?.announcementViewModel = nil // Dismiss announcement
+                    MainTabBarController.presentAddProductFlow()
+                })
+                self.announcementViewModel = viewModel
+            }
+        }
+        stores.dispatch(getVisibility)
+    }
+
     /// Checks for Just In Time Messages and prepares the announcement if needed.
     ///
     private func syncJustInTimeMessages(for siteID: Int64) {