Skip to content

Commit 94e5e5c

Browse files
authored
Merge pull request #8704 from woocommerce/issue/8523-release-bulk-editing
Bulk Editing: Remove feature flag and release
2 parents 40f9141 + feb9031 commit 94e5e5c

File tree

4 files changed

+12
-19
lines changed

4 files changed

+12
-19
lines changed

Experiments/Experiments/DefaultFeatureFlagService.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
6060
case .applicationPasswordAuthenticationForSiteCredentialLogin:
6161
// Enable this to test application password authentication (WIP)
6262
return false
63-
case .productsBulkEditing:
64-
return buildConfig == .localDeveloper || buildConfig == .alpha
6563
case .domainSettings:
6664
return buildConfig == .localDeveloper || buildConfig == .alpha
6765
default:

Experiments/Experiments/FeatureFlag.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,6 @@ public enum FeatureFlag: Int {
142142
///
143143
case applicationPasswordAuthenticationForSiteCredentialLogin
144144

145-
/// Bulk editing of status and price in products list
146-
///
147-
case productsBulkEditing
148-
149145
/// Whether to enable domain updates from the settings for a WPCOM site.
150146
///
151147
case domainSettings

RELEASE-NOTES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
12.0
44
-----
5+
- [**] Adds a feature of bulk updating products from the product's list. [https://github.com/woocommerce/woocommerce-ios/pull/8704]
56
- [internal] Store creation flow now includes 3 profiler questions: store category, selling status, and store country. [https://github.com/woocommerce/woocommerce-ios/pull/8667]
67

78
11.9

WooCommerce/Classes/ViewRelated/Products/ProductsViewController.swift

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -541,20 +541,18 @@ private extension ProductsViewController {
541541
}()
542542
rightBarButtonItems.append(searchItem)
543543

544-
if ServiceLocator.featureFlagService.isFeatureFlagEnabled(.productsBulkEditing) {
545-
let bulkEditItem: UIBarButtonItem = {
546-
let button = UIBarButtonItem(image: .multiSelectIcon,
547-
style: .plain,
548-
target: self,
549-
action: #selector(startBulkEditing))
550-
button.accessibilityTraits = .button
551-
button.accessibilityLabel = Localization.bulkEditingNavBarButtonTitle
552-
button.accessibilityHint = Localization.bulkEditingNavBarButtonHint
544+
let bulkEditItem: UIBarButtonItem = {
545+
let button = UIBarButtonItem(image: .multiSelectIcon,
546+
style: .plain,
547+
target: self,
548+
action: #selector(startBulkEditing))
549+
button.accessibilityTraits = .button
550+
button.accessibilityLabel = Localization.bulkEditingNavBarButtonTitle
551+
button.accessibilityHint = Localization.bulkEditingNavBarButtonHint
553552

554-
return button
555-
}()
556-
rightBarButtonItems.append(bulkEditItem)
557-
}
553+
return button
554+
}()
555+
rightBarButtonItems.append(bulkEditItem)
558556

559557
navigationItem.rightBarButtonItems = rightBarButtonItems
560558
}

0 commit comments

Comments
 (0)