Skip to content

Commit 9884f22

Browse files
committed
Rename dismiss methods to be more explicit
1 parent 6a53fd6 commit 9884f22

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

WooCommerce/Classes/ViewRelated/Orders/OrderListViewController.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -797,7 +797,7 @@ private extension OrderListViewController {
797797
let shareIPPFeedbackAction = TopBannerViewModel.ActionButton(title: Localization.shareFeedbackButton, action: { [weak self] _ in
798798
self?.displayIPPFeedbackBannerSurvey()
799799
// We dismiss the banner at this point as we cannot know if the user successfully submitted it
800-
self?.viewModel.IPPFeedbackWasDismissed()
800+
self?.viewModel.IPPFeedbackBannerWasDismissed()
801801
})
802802

803803
let viewModel = TopBannerViewModel(
@@ -829,12 +829,12 @@ private extension OrderListViewController {
829829
)
830830

831831
let remindMeLaterAction = UIAlertAction( title: Localization.remindMeLater, style: .default) { [weak self] _ in
832-
self?.viewModel.remindMeLaterTapped()
832+
self?.viewModel.IPPFeedbackBannerRemindMeLaterTapped()
833833
}
834834
actionSheet.addAction(remindMeLaterAction)
835835

836836
let dontShowAgainAction = UIAlertAction( title: Localization.dontShowAgain, style: .default) { [weak self] _ in
837-
self?.viewModel.dontShowAgainTapped()
837+
self?.viewModel.IPPFeedbackBannerDontShowAgainTapped()
838838
}
839839
actionSheet.addAction(dontShowAgainAction)
840840

WooCommerce/Classes/ViewRelated/Orders/OrderListViewModel.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -370,15 +370,15 @@ extension OrderListViewModel {
370370
stores.dispatch(updateBannerVisibility)
371371
}
372372

373-
func remindMeLaterTapped() {
373+
func IPPFeedbackBannerRemindMeLaterTapped() {
374374
dismissIPPFeedbackBanner(remindAfterDays: Constants.remindIPPBannerDismissalAfterDays)
375375
}
376376

377-
func dontShowAgainTapped() {
377+
func IPPFeedbackBannerDontShowAgainTapped() {
378378
dismissIPPFeedbackBanner(remindAfterDays: nil)
379379
}
380380

381-
func IPPFeedbackWasDismissed() {
381+
func IPPFeedbackBannerWasDismissed() {
382382
dismissIPPFeedbackBanner(remindAfterDays: nil)
383383
}
384384
}

0 commit comments

Comments
 (0)