Use confirmation instead of withCheckedContinuation

Author: staskus

WooCommerce/WooCommerceTests/POS/Mocks/MockPOSCatalogSettingsService.swift

@@ -4,14 +4,10 @@ final class MockPOSCatalogSettingsService: POSCatalogSettingsServiceProtocol {
     var catalogInfoResult: Result<POSCatalogInfo, Error> = .success(
         .init(productCount: 0, variationCount: 0, lastFullSyncDate: nil, lastIncrementalSyncDate: nil)
     )
-    var onLoadCatalogInfoCalled: ((_ continuation: CheckedContinuation<Void, Never>) -> Void)? = nil
+    var onLoadCatalogInfoCalled: (() -> Void)?
 
     func loadCatalogInfo(for siteID: Int64) async throws -> POSCatalogInfo {
-        if let onLoadCatalogInfoCalled {
-            await withCheckedContinuation { continuation in
-                onLoadCatalogInfoCalled(continuation)
-            }
-        }
+        onLoadCatalogInfoCalled?()
 
         switch catalogInfoResult {
         case .success(let info):

WooCommerce/WooCommerceTests/POS/Mocks/MockPOSCatalogSyncCoordinator.swift

@@ -10,14 +10,10 @@ final class MockPOSCatalogSyncCoordinator: POSCatalogSyncCoordinatorProtocol {
         true
     }
 
-    var onPerformFullSyncCalled: ((_ continuation: CheckedContinuation<Void, Never>) -> Void)? = nil
+    var onPerformFullSyncCalled: (() -> Void)?
 
     func performFullSync(for siteID: Int64) async throws {
-        if let onPerformFullSyncCalled {
-            await withCheckedContinuation { continuation in
-                onPerformFullSyncCalled(continuation)
-            }
-        }
+        onPerformFullSyncCalled?()
 
         performFullSyncInvocationCount += 1
         performFullSyncSiteID = siteID

WooCommerce/WooCommerceTests/POS/Presentation/Settings/POSSettingsLocalCatalogViewModelTests.swift

@@ -92,17 +92,17 @@ struct POSSettingsLocalCatalogViewModelTests {
             lastIncrementalSyncDate: nil
         ))
 
-        catalogSettingsService.onLoadCatalogInfoCalled = { continuation in
-            // When loadCatalogInfo is called, loading is set to true
-            #expect(sut.isLoading == true)
-
-            // Finsh loadCatalogInfo
-            continuation.resume()
+        await confirmation() { confirmation in
+            catalogSettingsService.onLoadCatalogInfoCalled = {
+                // At the time loadCatalogInfo is called, loading is set to true
+                #expect(sut.isLoading == true)
+                confirmation()
+            }
+
+            // When
+            await sut.loadCatalogData()
         }
 
-        // When
-        await sut.loadCatalogData()
-
         // Then
         #expect(sut.isLoading == false)
     }
@@ -137,17 +137,17 @@ struct POSSettingsLocalCatalogViewModelTests {
             lastIncrementalSyncDate: nil
         ))
 
-        catalogSyncCoordinator.onPerformFullSyncCalled = { continuation in
-            // When performFullSyncCalled is called, isRefreshingCatalog is set to true
-            #expect(sut.isRefreshingCatalog == true)
+        await confirmation() { confirmation in
+            catalogSyncCoordinator.onPerformFullSyncCalled = {
+                // At the time performFullSyncCalled is called, isRefreshingCatalog is set to true
+                #expect(sut.isRefreshingCatalog == true)
+                confirmation()
+            }
 
-            // Finsh performFullSync
-            continuation.resume()
+            // When
+            await sut.refreshCatalog()
         }
 
-        // When
-        await sut.refreshCatalog()
-
         // Then
         #expect(sut.isRefreshingCatalog == false)
     }