remove scanner as nav destination

iamgabrielma · iamgabrielma · commit 9fdcf3635a42 · 2025-08-27T08:06:05.000+07:00
At the moment the scanner child view only has buttons that will prompt modal flow or web view, so no need to be part of the nav stack further down.
diff --git a/WooCommerce/Classes/POS/Presentation/Settings/PointOfSaleSettingsHardwareDetailView.swift b/WooCommerce/Classes/POS/Presentation/Settings/PointOfSaleSettingsHardwareDetailView.swift
@@ -31,10 +31,6 @@ struct PointOfSaleSettingsHardwareDetailView: View {
                     cardReadersView
                 case .hardware(.scanners):
                     scannersView
-                case .scanner:
-                    // This case in the navigation stack is not reached,
-                    // as we present the destination modally instead of further navigation through the stack.
-                    EmptyView()
                 }
             }
             .posModal(isPresented: $showBarcodeScanningSetupModal) {
@@ -151,7 +147,6 @@ struct PointOfSaleSettingsHardwareDetailView: View {
 extension PointOfSaleSettingsHardwareDetailView {
     enum NavigationDestination: Hashable {
         case hardware(PointOfSaleSettingsView.HardwareDestination)
-        case scanner(ScannerDestination)
     }
 
     enum ScannerDestination: Identifiable, CaseIterable {

Original file line number	Diff line number	Diff line change
`@@ -31,10 +31,6 @@ struct PointOfSaleSettingsHardwareDetailView: View {`
`31`	`31`	`cardReadersView`
`32`	`32`	`case .hardware(.scanners):`
`33`	`33`	`scannersView`
`34`		`- case .scanner:`
`35`		`- // This case in the navigation stack is not reached,`
`36`		`- // as we present the destination modally instead of further navigation through the stack.`
`37`		`- EmptyView()`
`38`	`34`	`}`
`39`	`35`	`}`
`40`	`36`	`.posModal(isPresented: $showBarcodeScanningSetupModal) {`
`@@ -151,7 +147,6 @@ struct PointOfSaleSettingsHardwareDetailView: View {`
`151`	`147`	`extension PointOfSaleSettingsHardwareDetailView {`
`152`	`148`	`enum NavigationDestination: Hashable {`
`153`	`149`	`case hardware(PointOfSaleSettingsView.HardwareDestination)`
`154`		`- case scanner(ScannerDestination)`
`155`	`150`	`}`
`156`	`151`
`157`	`152`	`enum ScannerDestination: Identifiable, CaseIterable {`