Remove analyticsValue PaymentMethod dependency rom POS

Author: staskus

Modules/Sources/Yosemite/Tools/AsyncPaginationTracker.swift

@@ -13,8 +13,8 @@ public final class AsyncPaginationTracker {
     }
 
     /// Default pagination settings.
-    enum Defaults {
-        static let pageFirstIndex = Store.Default.firstPageNumber
+    public enum Defaults {
+        public static let pageFirstIndex = Store.Default.firstPageNumber
     }
 
     /// The index of the first page in the API. So far, both Woo and WP.com API have the first page index at 1.

WooCommerce/Classes/POS/Analytics/WooAnalyticsEvent+PointOfSale.swift

@@ -125,7 +125,7 @@ extension WooAnalyticsEvent {
                 Key.cardReaderModel: readerModel(for: cardReaderModel),
                 Key.countryCode: countryCode.rawValue,
                 Key.gatewayID: safeGatewayID(for: forGatewayID),
-                Key.paymentMethodType: paymentMethod.analyticsValue,
+                Key.paymentMethodType: analyticsValue(for: paymentMethod),
                 Key.millisecondsSinceCustomerInteractionStarted: "\(millisecondsSinceCustomerIteractionStarted)",
                 Key.millisecondsSinceOrderSyncSuccess: "\(millisecondsSinceOrderSyncSuccess)",
                 Key.millisecondsSinceReaderReadyToCollect: "\(millisecondsSinceReaderReadyToCollect)",
@@ -134,6 +134,17 @@ extension WooAnalyticsEvent {
             ])
         }
 
+        static func analyticsValue(for paymentMethod: PaymentMethod) -> String {
+            switch paymentMethod {
+            case .card, .cardPresent:
+                return "card"
+            case .interacPresent:
+                return "card_interac"
+            case .unknown:
+                return "unknown"
+            }
+        }
+
         static func cashCollectPaymentSuccess(millisecondsSinceCustomerIteractionStarted: Double) -> WooAnalyticsEvent {
             WooAnalyticsEvent(statName: .pointOfSaleCashCollectPaymentSuccess, properties: [
                 Key.millisecondsSinceCustomerInteractionStarted: "\(millisecondsSinceCustomerIteractionStarted)",