Update analytics tests for POS cash payment flow

See 363e0b0 for details – we moved the other event to be for the final step, not starting the flow.

Author: joshheald

WooCommerce/WooCommerceTests/POS/Mocks/MockPOSCollectOrderPaymentAnalyticsTracker.swift

@@ -28,8 +28,9 @@ final class MockPOSCollectOrderPaymentAnalyticsTracker: POSCollectOrderPaymentAn
         // no-op
     }
 
+    var didCallTrackSuccessfulCashPayment = false
     func trackSuccessfulCashPayment() {
-        // no-op
+        didCallTrackSuccessfulCashPayment = true
     }
 
     var connectedReaderModel: String?

WooCommerce/WooCommerceTests/POS/Models/PointOfSaleAggregateModelTests.swift

@@ -906,7 +906,20 @@ struct PointOfSaleAggregateModelTests {
             await sut.startCashPayment()
 
             // Then
-            #expect(mockAnalyticsProvider.receivedEvents.first(where: { $0 == "cash_payment_tapped" }) != nil)
+            #expect(mockAnalyticsProvider.receivedEvents.first(where: { $0 == "checkout_cash_payment_tapped" }) != nil)
+        }
+
+        @Test func collectCashPayment_when_invoked_tracks_expected_event() async throws {
+            // Given
+            let analyticsTracker = MockPOSCollectOrderPaymentAnalyticsTracker()
+            let sut = makePointOfSaleAggregateModel(orderController: orderController,
+                                                    collectOrderPaymentAnalyticsTracker: analyticsTracker)
+
+            // When
+            try await sut.collectCashPayment(changeDueAmount: "0.00")
+
+            // Then
+            #expect(analyticsTracker.didCallTrackSuccessfulCashPayment == true)
         }
     }