Rename constants for readability

Author: iamgabrielma

WooCommerce/Classes/Extensions/UIButton+Helpers.swift

@@ -10,10 +10,10 @@ extension UIButton {
     func applyPrimaryButtonStyle() {
         var configuration = UIButton.Configuration.filled()
         configuration.contentInsets = .init(
-            top: Style.defaultVerticalInsets,
-            leading: Style.defaultHorizontalInsets,
-            bottom: Style.defaultVerticalInsets,
-            trailing: Style.defaultHorizontalInsets
+            top: Style.verticalInset,
+            leading: Style.horizontalInset,
+            bottom: Style.verticalInset,
+            trailing: Style.horizontalInset
         )
         layer.borderColor = UIColor.primaryButtonBorder.cgColor
         layer.borderWidth = Style.defaultBorderWidth
@@ -47,10 +47,10 @@ extension UIButton {
     func applySecondaryButtonStyle() {
         var configuration = UIButton.Configuration.filled()
         configuration.contentInsets = .init(
-            top: Style.defaultVerticalInsets,
-            leading: Style.defaultHorizontalInsets,
-            bottom: Style.defaultVerticalInsets,
-            trailing: Style.defaultHorizontalInsets
+            top: Style.verticalInset,
+            leading: Style.horizontalInset,
+            bottom: Style.verticalInset,
+            trailing: Style.horizontalInset
         )
         backgroundColor = .secondaryButtonBackground
         layer.borderColor = UIColor.secondaryButtonBorder.cgColor
@@ -85,10 +85,10 @@ extension UIButton {
     func applyLinkButtonStyle(enableMultipleLines: Bool = false) {
         var configuration = UIButton.Configuration.plain()
         configuration.contentInsets = .init(
-            top: Style.defaultVerticalInsets,
-            leading: Style.defaultHorizontalInsets,
-            bottom: Style.defaultVerticalInsets,
-            trailing: Style.defaultHorizontalInsets
+            top: Style.verticalInset,
+            leading: Style.horizontalInset,
+            bottom: Style.verticalInset,
+            trailing: Style.horizontalInset
         )
         backgroundColor = .clear
         tintColor = .accent
@@ -115,10 +115,10 @@ extension UIButton {
     func applyPaymentsModalCancelButtonStyle() {
         var configuration = UIButton.Configuration.plain()
         configuration.contentInsets = .init(
-            top: Style.defaultVerticalInsets,
-            leading: Style.defaultHorizontalInsets,
-            bottom: Style.defaultVerticalInsets,
-            trailing: Style.defaultHorizontalInsets
+            top: Style.verticalInset,
+            leading: Style.horizontalInset,
+            bottom: Style.verticalInset,
+            trailing: Style.horizontalInset
         )
         backgroundColor = .tertiarySystemBackground
         layer.borderColor = UIColor.secondaryButtonBorder.cgColor
@@ -193,7 +193,7 @@ private extension UIButton {
     struct Style {
         static let defaultCornerRadius = CGFloat(8.0)
         static let defaultBorderWidth = CGFloat(1.0)
-        static let defaultVerticalInsets = CGFloat(12)
-        static let defaultHorizontalInsets = CGFloat(22)
+        static let verticalInset = CGFloat(12)
+        static let horizontalInset = CGFloat(22)
     }
 }

WooCommerce/Classes/ViewRelated/ReusableViews/VerticalButton.swift

@@ -44,9 +44,9 @@ class VerticalButton: UIButton {
         var configuration = UIButton.Configuration.filled()
         configuration.contentInsets = .init(
             top: .zero,
-            leading: Settings.horizontalEdgeInsets,
+            leading: Settings.inset,
             bottom: .zero,
-            trailing: Settings.horizontalEdgeInsets
+            trailing: Settings.inset
         )
         layer.cornerRadius = Settings.cornerRadius
         titleLabel?.font = UIFont.footnote
@@ -60,7 +60,7 @@ private extension VerticalButton {
 
     enum Settings {
         static let cornerRadius     = CGFloat(10)
-        static let horizontalEdgeInsets = CGFloat(5)
+        static let inset            = CGFloat(5)
         static let labelPaddingTop  = CGFloat(2)
     }
 }

WooCommerce/Classes/ViewRelated/Survey/SurveySubmittedViewController.swift

@@ -93,9 +93,9 @@ private extension SurveySubmittedViewController {
 
         contactUsButton.applyLinkButtonStyle()
         contactUsButton.titleLabel?.applyCalloutStyle()
-        var contactUsconfiguration = UIButton.Configuration.plain()
-        contactUsconfiguration.contentInsets = .init(.zero)
-        contactUsButton.configuration = contactUsconfiguration
+        var contactUsConfiguration = UIButton.Configuration.plain()
+        contactUsConfiguration.contentInsets = .init(.zero)
+        contactUsButton.configuration = contactUsConfiguration
     }
 
     /// Apply the correspondent localized texts to each component