Replace computed variables for fetched objects

Author: itsmeichigo

WooCommerce/Classes/ViewRelated/Blaze/CampaignCreation/BlazeCampaignCreationFormViewModel.swift

@@ -203,13 +203,7 @@ final class BlazeCampaignCreationFormViewModel: ObservableObject {
     @Published private(set) var isUsingAISuggestions: Bool = false
 
     private let storage: StorageManagerType
-    private var product: ProductListItem? {
-        guard let product = productsResultsController.listItemObjects.first else {
-            assertionFailure("Unable to fetch product with ID: \(productID)")
-            return nil
-        }
-        return product
-    }
+    private var product: ProductListItem?
 
     @Published private(set) var error: BlazeCampaignCreationError?
     private var suggestions: [BlazeAISuggestion] = []
@@ -306,6 +300,8 @@ final class BlazeCampaignCreationFormViewModel: ObservableObject {
         // sets isEvergreen = true by default if evergreen campaigns are supported
         self.isEvergreen = featureFlagService.isFeatureFlagEnabled(.blazeEvergreenCampaigns)
 
+        product = productsResultsController.listItemObjects.first
+
         initializeCampaignObjective()
         updateBudgetDetails()
         updateTargetLanguagesText()

WooCommerce/Classes/ViewRelated/Dashboard/Blaze/BlazeCampaignDashboardViewModel.swift

@@ -100,9 +100,7 @@ final class BlazeCampaignDashboardViewModel: ObservableObject {
                                                  sortOrder: .dateDescending)
     }()
 
-    var latestPublishedProduct: ProductListItem? {
-        productResultsController.listItemObjects.first
-    }
+    private(set) var latestPublishedProduct: ProductListItem?
 
     private var subscriptions: Set<AnyCancellable> = []
 
@@ -315,8 +313,10 @@ private extension BlazeCampaignDashboardViewModel {
         }
 
         productResultsController.onDidChangeContent = { [weak self] in
-            self?.updateAvailability()
-            self?.updateResults()
+            guard let self else { return }
+            latestPublishedProduct = productResultsController.listItemObjects.first
+            updateAvailability()
+            updateResults()
         }
         productResultsController.onDidResetContent = { [weak self] in
             self?.updateAvailability()
@@ -326,6 +326,7 @@ private extension BlazeCampaignDashboardViewModel {
         do {
             try blazeCampaignResultsController.performFetch()
             try productResultsController.performFetch()
+            latestPublishedProduct = productResultsController.listItemObjects.first
             updateResults()
         } catch {
             ServiceLocator.crashLogging.logError(error)

WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShipping Items Section/WooShippingItemsDataSource.swift

@@ -30,10 +30,7 @@ final class DefaultWooShippingItemsDataSource: WooShippingItemsDataSource {
 
     /// Stored products that match the items in the order.
     ///
-    private var products: [ProductListItem] {
-        try? productResultsController.performFetch()
-        return productResultsController.listItemObjects
-    }
+    private var products: [ProductListItem] = []
 
     /// Stored product variations that match the items in the order.
     ///
@@ -79,6 +76,7 @@ final class DefaultWooShippingItemsDataSource: WooShippingItemsDataSource {
     private func configureProductResultsController() {
         do {
             try productResultsController.performFetch()
+            products = productResultsController.listItemObjects
         } catch {
             DDLogError("⛔️ Error fetching products for Woo Shipping label creation: \(error)")
         }