Refresh A/B tests after each refreshUserData where ExPlat.shared is reset.

Author: jaclync

Experiments/Experiments/ABTest.swift

@@ -52,6 +52,7 @@ public enum ABTest: String, CaseIterable {
 public extension ABTest {
     /// Start the AB Testing platform if any experiment exists for the provided context
     ///
+    @MainActor
     static func start(for context: ExperimentContext) async {
         let experiments = ABTest.allCases.filter { $0.context == context }
 

WooCommerce/Classes/Analytics/WooAnalytics.swift

@@ -1,3 +1,4 @@
+import Experiments
 import Foundation
 import UIKit
 import WordPressShared
@@ -60,6 +61,15 @@ public extension WooAnalytics {
         }
 
         analyticsProvider.refreshUserData()
+
+        // Refreshes A/B experiments since `ExPlat.shared` is reset after each `TracksProvider.refreshUserData` call
+        // and any A/B test assignments that come back after the shared instance is reset won't be saved for later
+        // access.
+        let context: ExperimentContext = ServiceLocator.stores.isAuthenticated ?
+            .loggedIn: .loggedOut
+        Task { @MainActor in
+            await ABTest.start(for: context)
+        }
     }
 
     /// Track a spcific event without any associated properties

WooCommerce/Classes/AppDelegate.swift

@@ -73,15 +73,12 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
         // ever new source code is injected into our application.
         Inject.animation = .interactiveSpring()
 
-        Task { @MainActor in
-            await startABTesting()
-
-            // Upgrade check...
-            // This has to be called after A/B testing setup in `startABTesting` if any of the Tracks events
-            // in `checkForUpgrades` is used as an exposure event for an experiment.
-            // For example, `application_installed` could be the exposure event for logged-out experiments.
-            checkForUpgrades()
-        }
+        // Upgrade check...
+        // This has to be called after A/B testing setup in `setupAnalytics` (which calls
+        // `WooAnalytics.refreshUserData`) if any of the Tracks events in `checkForUpgrades` is
+        // used as an exposure event for an experiment.
+        // For example, `application_installed` could be the exposure event for logged-out experiments.
+        checkForUpgrades()
 
         return true
     }
@@ -372,13 +369,6 @@ private extension AppDelegate {
         }
     }
 
-    /// Starts the AB testing platform and fetches test assignments for the current context
-    ///
-    func startABTesting() async {
-        let context: ExperimentContext = ServiceLocator.stores.isAuthenticated ? .loggedIn : .loggedOut
-        await ABTest.start(for: context)
-    }
-
     /// Tracks if the application was opened via a widget tap.
     ///
     func trackWidgetTappedIfNeeded(userActivity: NSUserActivity) {

WooCommerce/Classes/Authentication/Epilogue/StorePickerViewController.swift

@@ -201,7 +201,6 @@ final class StorePickerViewController: UIViewController {
         switch configuration {
         case .login:
             startListeningToNotifications()
-            startABTesting()
         case .switchingStores:
             secondaryActionButton.isHidden = true
         default:
@@ -574,17 +573,6 @@ private extension StorePickerViewController {
         fancyAlert.transitioningDelegate = AppDelegate.shared.tabBarController
         present(fancyAlert, animated: true)
     }
-
-    /// Refreshes the AB testing assignments (refresh is needed after a user logs in)
-    ///
-    func startABTesting() {
-        guard ServiceLocator.stores.isAuthenticated else {
-            return
-        }
-        Task { @MainActor in
-            await ABTest.start(for: .loggedIn)
-        }
-    }
 }
 
 // MARK: Transition Controller Delegate

WooCommerce/Classes/Yosemite/DefaultStoresManager.swift

@@ -178,11 +178,6 @@ class DefaultStoresManager: StoresManager {
 
         updateAndReloadWidgetInformation(with: nil)
 
-        // Refresh the A/B test assignments for the logged-out context
-        Task { @MainActor in
-            await ABTest.start(for: .loggedOut)
-        }
-
         NotificationCenter.default.post(name: .logOutEventReceived, object: nil)
 
         return self