Skip to content

Commit a985dc9

Browse files
committed
Remove feature flag for products bulk editing
1 parent c93884f commit a985dc9

File tree

3 files changed

+11
-19
lines changed

3 files changed

+11
-19
lines changed

Experiments/Experiments/DefaultFeatureFlagService.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
6060
case .applicationPasswordAuthenticationForSiteCredentialLogin:
6161
// Enable this to test application password authentication (WIP)
6262
return false
63-
case .productsBulkEditing:
64-
return buildConfig == .localDeveloper || buildConfig == .alpha
6563
case .domainSettings:
6664
return buildConfig == .localDeveloper || buildConfig == .alpha
6765
default:

Experiments/Experiments/FeatureFlag.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,6 @@ public enum FeatureFlag: Int {
142142
///
143143
case applicationPasswordAuthenticationForSiteCredentialLogin
144144

145-
/// Bulk editing of status and price in products list
146-
///
147-
case productsBulkEditing
148-
149145
/// Whether to enable domain updates from the settings for a WPCOM site.
150146
///
151147
case domainSettings

WooCommerce/Classes/ViewRelated/Products/ProductsViewController.swift

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -539,20 +539,18 @@ private extension ProductsViewController {
539539
}()
540540
rightBarButtonItems.append(searchItem)
541541

542-
if ServiceLocator.featureFlagService.isFeatureFlagEnabled(.productsBulkEditing) {
543-
let bulkEditItem: UIBarButtonItem = {
544-
let button = UIBarButtonItem(image: .multiSelectIcon,
545-
style: .plain,
546-
target: self,
547-
action: #selector(startBulkEditing))
548-
button.accessibilityTraits = .button
549-
button.accessibilityLabel = Localization.bulkEditingNavBarButtonTitle
550-
button.accessibilityHint = Localization.bulkEditingNavBarButtonHint
542+
let bulkEditItem: UIBarButtonItem = {
543+
let button = UIBarButtonItem(image: .multiSelectIcon,
544+
style: .plain,
545+
target: self,
546+
action: #selector(startBulkEditing))
547+
button.accessibilityTraits = .button
548+
button.accessibilityLabel = Localization.bulkEditingNavBarButtonTitle
549+
button.accessibilityHint = Localization.bulkEditingNavBarButtonHint
551550

552-
return button
553-
}()
554-
rightBarButtonItems.append(bulkEditItem)
555-
}
551+
return button
552+
}()
553+
rightBarButtonItems.append(bulkEditItem)
556554

557555
navigationItem.rightBarButtonItems = rightBarButtonItems
558556
}

0 commit comments

Comments
 (0)