Add PriceInputViewControllerTests

Author: ealeksandrov

WooCommerce/Classes/ViewRelated/Products/PriceInputViewController.swift

@@ -15,9 +15,13 @@ final class PriceInputViewController: UIViewController {
         return noticePresenter
     }()
 
-    init(viewModel: PriceInputViewModel) {
+    init(viewModel: PriceInputViewModel, noticePresenter: NoticePresenter? = nil) {
         self.viewModel = viewModel
         super.init(nibName: nil, bundle: nil)
+
+        if let noticePresenter {
+            self.noticePresenter = noticePresenter
+        }
     }
     required init?(coder: NSCoder) {
         fatalError("init(coder:) has not been implemented")

WooCommerce/WooCommerce.xcodeproj/project.pbxproj

@@ -1277,6 +1277,7 @@
 		AEE9A880293A3E5500227C92 /* RefreshablePlainList.swift in Sources */ = {isa = PBXBuildFile; fileRef = AEE9A87F293A3E5500227C92 /* RefreshablePlainList.swift */; };
 		AEFF77A42978389400667F7A /* PriceInputViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = AEFF77A32978389400667F7A /* PriceInputViewController.swift */; };
 		AEFF77A629783CA600667F7A /* PriceInputViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = AEFF77A529783CA600667F7A /* PriceInputViewModel.swift */; };
+		AEFF77A829786A2900667F7A /* PriceInputViewControllerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = AEFF77A729786A2900667F7A /* PriceInputViewControllerTests.swift */; };
 		B50911302049E27A007D25DC /* DashboardViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = B509112D2049E27A007D25DC /* DashboardViewController.swift */; };
 		B509FED121C041DF000076A9 /* Locale+Woo.swift in Sources */ = {isa = PBXBuildFile; fileRef = B509FED021C041DF000076A9 /* Locale+Woo.swift */; };
 		B509FED321C05121000076A9 /* SupportManagerAdapter.swift in Sources */ = {isa = PBXBuildFile; fileRef = B509FED221C05121000076A9 /* SupportManagerAdapter.swift */; };
@@ -3333,6 +3334,7 @@
 		AEE9A87F293A3E5500227C92 /* RefreshablePlainList.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RefreshablePlainList.swift; sourceTree = "<group>"; };
 		AEFF77A32978389400667F7A /* PriceInputViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PriceInputViewController.swift; sourceTree = "<group>"; };
 		AEFF77A529783CA600667F7A /* PriceInputViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PriceInputViewModel.swift; sourceTree = "<group>"; };
+		AEFF77A729786A2900667F7A /* PriceInputViewControllerTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PriceInputViewControllerTests.swift; sourceTree = "<group>"; };
 		B509112D2049E27A007D25DC /* DashboardViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DashboardViewController.swift; sourceTree = "<group>"; };
 		B509FED021C041DF000076A9 /* Locale+Woo.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Locale+Woo.swift"; sourceTree = "<group>"; };
 		B509FED221C05121000076A9 /* SupportManagerAdapter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SupportManagerAdapter.swift; sourceTree = "<group>"; };
@@ -5433,6 +5435,7 @@
 			children = (
 				093B265827DF15100026F92D /* BulkUpdatePriceViewControllerTests.swift */,
 				09BE3A9027C921A70070B69D /* BulkUpdatePriceSettingsViewModelTests.swift */,
+				AEFF77A729786A2900667F7A /* PriceInputViewControllerTests.swift */,
 			);
 			path = "Bulk Edit Price";
 			sourceTree = "<group>";
@@ -11642,6 +11645,7 @@
 				57A5D8D92534FEBB00AA54D6 /* TotalRefundedCalculationUseCaseTests.swift in Sources */,
 				B5718D6521B56B400026C9F0 /* PushNotificationsManagerTests.swift in Sources */,
 				D8A8C4F32268288F001C72BF /* AddManualCustomTrackingViewModelTests.swift in Sources */,
+				AEFF77A829786A2900667F7A /* PriceInputViewControllerTests.swift in Sources */,
 				02C2756F24F5F5EE00286C04 /* ProductShippingSettingsViewModel+ProductVariationTests.swift in Sources */,
 				571FDDAE24C768DC00D486A5 /* MockZendeskManager.swift in Sources */,
 				45FBDF3C238D4EA800127F77 /* ExtendedAddProductImageCollectionViewCellTests.swift in Sources */,

WooCommerce/WooCommerceTests/ViewRelated/Products/Edit Product/Edit Price/Bulk Edit Price/PriceInputViewControllerTests.swift

@@ -0,0 +1,70 @@
+import Foundation
+import XCTest
+import Yosemite
+
+@testable import WooCommerce
+
+/// Tests for `PriceInputViewController`.
+///
+final class PriceInputViewControllerTests: XCTestCase {
+    private let sampleSiteID: Int64 = 123
+    private var storesManager: MockStoresManager!
+
+    override func setUp() {
+        super.setUp()
+        storesManager = MockStoresManager(sessionManager: .makeForTesting())
+    }
+
+    override func tearDown() {
+        storesManager = nil
+        super.tearDown()
+    }
+
+    func test_view_controller_displays_notice_on_selected_regular_price_is_less_than_sale_price_validation_error() throws {
+        // Given
+        let noticePresenter = MockNoticePresenter()
+        let listViewModel = ProductListViewModel(siteID: sampleSiteID, stores: storesManager)
+        let sampleProduct1 = Product.fake().copy(productID: 1, dateOnSaleStart: Date(), dateOnSaleEnd: Date(), regularPrice: "100", salePrice: "42")
+        listViewModel.selectProduct(sampleProduct1)
+
+        let viewModel = PriceInputViewModel(productListViewModel: listViewModel)
+        let viewController = PriceInputViewController(viewModel: viewModel, noticePresenter: noticePresenter)
+
+        // When
+        _ = try XCTUnwrap(viewController.view)
+        viewModel.handlePriceChange("24")
+        viewModel.applyButtonTapped()
+
+        waitUntil {
+            noticePresenter.queuedNotices.count == 1
+        }
+
+        // Then
+        let notice = try XCTUnwrap(noticePresenter.queuedNotices.first)
+        XCTAssertEqual(notice.feedbackType, .error)
+    }
+
+    func test_view_controller_displays_notice_on_no_regular_price_validation_error() throws {
+        // Given
+        let noticePresenter = MockNoticePresenter()
+        let listViewModel = ProductListViewModel(siteID: sampleSiteID, stores: storesManager)
+        let sampleProduct1 = Product.fake().copy(productID: 1, dateOnSaleStart: Date(), dateOnSaleEnd: Date(), regularPrice: "100", salePrice: "42")
+        listViewModel.selectProduct(sampleProduct1)
+
+        let viewModel = PriceInputViewModel(productListViewModel: listViewModel)
+        let viewController = PriceInputViewController(viewModel: viewModel, noticePresenter: noticePresenter)
+
+        // When
+        _ = try XCTUnwrap(viewController.view)
+        viewModel.handlePriceChange("")
+        viewModel.applyButtonTapped()
+
+        waitUntil {
+            noticePresenter.queuedNotices.count == 1
+        }
+
+        // Then
+        let notice = try XCTUnwrap(noticePresenter.queuedNotices.first)
+        XCTAssertEqual(notice.feedbackType, .error)
+    }
+}