Add fallback when onSale field value is a string

Author: rachelmcr

Networking/Networking/Model/Product/Product.swift

@@ -370,7 +370,11 @@ public struct Product: Codable, GeneratedCopiable, Equatable, GeneratedFakeable
                                                              alternativeTypes: [.decimal(transform: { NSDecimalNumber(decimal: $0).stringValue })])
             ?? ""
 
-        let onSale = try container.decode(Bool.self, forKey: .onSale)
+        // Even though WooCommerce Core returns Bool values,
+        // some plugins alter the field value from Bool to String.
+        let onSale = container.failsafeDecodeIfPresent(targetType: Bool.self,
+                                                       forKey: .onSale,
+                                                       alternativeTypes: [ .string(transform: { NSString(string: $0).boolValue })]) ?? false
 
         // Even though a plain install of WooCommerce Core provides string values,
         // some plugins alter the field value from String to Int or Decimal.

Networking/Networking/Model/Product/ProductVariation.swift

@@ -219,7 +219,12 @@ public struct ProductVariation: Codable, GeneratedCopiable, Equatable, Generated
                                                              forKey: .regularPrice,
                                                              alternativeTypes: [.decimal(transform: { NSDecimalNumber(decimal: $0).stringValue })])
             ?? ""
-        let onSale = try container.decode(Bool.self, forKey: .onSale)
+
+        // Even though WooCommerce Core returns Bool values,
+        // some plugins alter the field value from Bool to String.
+        let onSale = container.failsafeDecodeIfPresent(targetType: Bool.self,
+                                                       forKey: .onSale,
+                                                       alternativeTypes: [ .string(transform: { NSString(string: $0).boolValue })]) ?? false
 
         // Even though a plain install of WooCommerce Core provides string values,
         // some plugins alter the field value from String to Int or Decimal.

Networking/NetworkingTests/Mapper/ProductMapperTests.swift

@@ -118,6 +118,7 @@ final class ProductMapperTests: XCTestCase {
         XCTAssertTrue(product.purchasable)
         XCTAssertEqual(product.permalink, "")
         XCTAssertEqual(product.backordersAllowed, true)
+        XCTAssertEqual(product.onSale, false)
     }
 
     /// Verifies that the `salePrice` field of the Product are parsed correctly when the product is on sale, and the sale price is an empty string

Networking/NetworkingTests/Mapper/ProductVariationMapperTests.swift

@@ -41,6 +41,7 @@ final class ProductVariationMapperTests: XCTestCase {
         XCTAssertTrue(productVariation.purchasable)
         XCTAssertEqual(productVariation.permalink, "")
         XCTAssertEqual(productVariation.backordersAllowed, true)
+        XCTAssertEqual(productVariation.onSale, false)
     }
 
     /// Test that the fields for variations of a subscription product are properly parsed.

Networking/NetworkingTests/Responses/product-alternative-types.json

@@ -23,7 +23,7 @@
             "date_on_sale_to": null,
             "date_on_sale_to_gmt": "2019-10-27T21:29:59",
             "price_html": "Free",
-            "on_sale": false,
+            "on_sale": "",
             "purchasable": 1,
             "total_sales": 0,
             "virtual": true,

Networking/NetworkingTests/Responses/product-variation-alternative-types.json

@@ -16,7 +16,7 @@
             "date_on_sale_from_gmt": "2019-10-15T21:30:00",
             "date_on_sale_to": "2019-10-27T23:59:59",
             "date_on_sale_to_gmt": "2019-10-27T21:29:59",
-            "on_sale": false,
+            "on_sale": "0",
             "status": "publish",
             "purchasable": 1,
             "virtual": false,