POSCatalogSyncRemote: remove productTypes parameter from products incremental sync, as product types filtering is not supported in full sync at least for now.

Author: jaclync

Modules/Sources/Networking/Remote/POSCatalogSyncRemote.swift

@@ -10,17 +10,15 @@ public class POSCatalogSyncRemote: Remote {
     /// - Parameters:
     ///   - modifiedAfter: Only products modified after this date will be returned.
     ///   - siteID: Site ID to load products from.
-    ///   - productTypes: Product types to filter by.
     ///   - pageNumber: Page number for pagination.
     /// - Returns: Paginated list of POS products.
     ///
     // periphery:ignore - TODO - remove this periphery ignore comment when this endpoint is integrated with catalog sync
-    public func loadProducts(modifiedAfter: Date, siteID: Int64, productTypes: [ProductType] = [.simple, .variable], pageNumber: Int)
+    public func loadProducts(modifiedAfter: Date, siteID: Int64, pageNumber: Int)
     async throws -> PagedItems<POSProduct> {
         let path = "products"
         let parameters = [
             ParameterKey.modifiedAfter: dateFormatter.string(from: modifiedAfter),
-            ParameterKey.productTypes: productTypes.map { $0.rawValue }.joined(separator: ","),
             ParameterKey.page: String(pageNumber),
             ParameterKey.perPage: String(Constants.defaultPageSize),
             ParameterKey.fields: POSProduct.requestFields.joined(separator: ",")
@@ -68,7 +66,6 @@ private extension POSCatalogSyncRemote {
 
     enum ParameterKey {
         static let modifiedAfter = "modified_after"
-        static let productTypes = "include_types"
         static let page = "page"
         static let perPage = "per_page"
         static let fields = "_fields"

Modules/Tests/NetworkingTests/Remote/POSCatalogSyncRemoteTests.swift

@@ -11,19 +11,17 @@ struct POSCatalogSyncRemoteTests {
         // Given
         let remote = POSCatalogSyncRemote(network: network)
         let modifiedAfter = Date(timeIntervalSince1970: 1692968400) // 2023-08-25 12:00:00 UTC
-        let productTypes: [ProductType] = [.simple, .variable]
         let pageNumber = 2
 
         // When
-        _ = try? await remote.loadProducts(modifiedAfter: modifiedAfter, siteID: sampleSiteID, productTypes: productTypes, pageNumber: pageNumber)
+        _ = try? await remote.loadProducts(modifiedAfter: modifiedAfter, siteID: sampleSiteID, pageNumber: pageNumber)
 
         // Then
         let queryParametersDictionary = try #require(network.queryParametersDictionary as? [String: any Hashable])
         let dateFormatter = ISO8601DateFormatter()
         let expectedDateString = dateFormatter.string(from: modifiedAfter)
 
         #expect(queryParametersDictionary["modified_after"] as? String == expectedDateString)
-        #expect(queryParametersDictionary["include_types"] as? String == "simple,variable")
         #expect(queryParametersDictionary["page"] as? String == String(pageNumber))
         #expect(queryParametersDictionary["per_page"] as? String == "100")
         #expect(queryParametersDictionary["_fields"] as? String == POSProduct.requestFields.joined(separator: ","))
@@ -33,12 +31,11 @@ struct POSCatalogSyncRemoteTests {
         // Given
         let remote = POSCatalogSyncRemote(network: network)
         let modifiedAfter = Date()
-        let productTypes: [ProductType] = [.simple]
         let expectedProductsCount = 2
 
         // When
         network.simulateResponse(requestUrlSuffix: "products", filename: "products-load-pos")
-        let pagedProducts = try await remote.loadProducts(modifiedAfter: modifiedAfter, siteID: sampleSiteID, productTypes: productTypes, pageNumber: 1)
+        let pagedProducts = try await remote.loadProducts(modifiedAfter: modifiedAfter, siteID: sampleSiteID, pageNumber: 1)
 
         // Then
         #expect(pagedProducts.items.count == expectedProductsCount)
@@ -55,7 +52,7 @@ struct POSCatalogSyncRemoteTests {
 
         // When/Then
         await #expect(throws: NetworkError.notFound()) {
-            try await remote.loadProducts(modifiedAfter: Date(), siteID: sampleSiteID, productTypes: [.simple], pageNumber: 1)
+            try await remote.loadProducts(modifiedAfter: Date(), siteID: sampleSiteID, pageNumber: 1)
         }
     }
 
@@ -70,7 +67,6 @@ struct POSCatalogSyncRemoteTests {
         let pagedProducts = try await remote.loadProducts(
             modifiedAfter: modifiedAfter,
             siteID: sampleSiteID,
-            productTypes: [.simple],
             pageNumber: pageNumber
         )
 
@@ -89,7 +85,6 @@ struct POSCatalogSyncRemoteTests {
         let pagedProducts = try await remote.loadProducts(
             modifiedAfter: modifiedAfter,
             siteID: sampleSiteID,
-            productTypes: [.simple],
             pageNumber: pageNumber
         )
 
@@ -109,7 +104,6 @@ struct POSCatalogSyncRemoteTests {
         let pagedProducts = try await remote.loadProducts(
             modifiedAfter: modifiedAfter,
             siteID: sampleSiteID,
-            productTypes: [.simple],
             pageNumber: 1
         )
 
@@ -128,7 +122,6 @@ struct POSCatalogSyncRemoteTests {
         let pagedProducts = try await remote.loadProducts(
             modifiedAfter: modifiedAfter,
             siteID: sampleSiteID,
-            productTypes: [.simple],
             pageNumber: 1
         )
 
@@ -281,7 +274,7 @@ struct POSCatalogSyncRemoteTests {
 
         // When
         network.simulateResponse(requestUrlSuffix: "products", filename: "empty-data-array")
-        _ = try? await remote.loadProducts(modifiedAfter: modifiedAfter, siteID: sampleSiteID, productTypes: [.simple], pageNumber: largePageNumber)
+        _ = try? await remote.loadProducts(modifiedAfter: modifiedAfter, siteID: sampleSiteID, pageNumber: largePageNumber)
 
         // Then
         let queryParametersDictionary = try #require(network.queryParametersDictionary as? [String: any Hashable])