Skip to content

Commit afbb75d

Browse files
committed
Re-arrange sheet and toolbar modifiers to avoid stale keybard accessory
1 parent 79a6f56 commit afbb75d

File tree

1 file changed

+37
-35
lines changed

1 file changed

+37
-35
lines changed

WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShippingAddresses/WooShippingEditAddressView.swift

Lines changed: 37 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,6 @@ struct WooShippingEditAddressView: View {
9191
previousFocusedField = newField
9292
}
9393
.toolbar {
94-
ToolbarItem(placement: .cancellationAction) {
95-
Button(Localization.cancel) {
96-
dismiss()
97-
}
98-
}
9994
ToolbarItemGroup(placement: .keyboard) {
10095
Button(action: {
10196
focusPreviousField()
@@ -118,36 +113,11 @@ struct WooShippingEditAddressView: View {
118113
}
119114
}
120115
}
121-
.sheet(isPresented: $isPresentingCountrySelector) {
122-
NavigationStack {
123-
FilterListSelector(viewModel: viewModel.countrySelectorVM)
124-
.navigationBarTitleDisplayMode(.inline)
125-
.toolbar {
126-
ToolbarItem(placement: .confirmationAction) {
127-
Button {
128-
isPresentingCountrySelector = false
129-
} label: {
130-
Text(Localization.done)
131-
.bold()
132-
}
133-
}
134-
}
135-
}
136-
}
137-
.sheet(isPresented: $isPresentingStateSelector) {
138-
NavigationStack {
139-
FilterListSelector(viewModel: viewModel.stateSelectorVM)
140-
.navigationBarTitleDisplayMode(.inline)
141-
.toolbar {
142-
ToolbarItem(placement: .confirmationAction) {
143-
Button {
144-
isPresentingStateSelector = false
145-
} label: {
146-
Text(Localization.done)
147-
.bold()
148-
}
149-
}
150-
}
116+
}
117+
.toolbar {
118+
ToolbarItem(placement: .cancellationAction) {
119+
Button(Localization.cancel) {
120+
dismiss()
151121
}
152122
}
153123
}
@@ -161,6 +131,38 @@ struct WooShippingEditAddressView: View {
161131
WooShippingNormalizeAddressView(viewModel: viewModel)
162132
}
163133
}
134+
.sheet(isPresented: $isPresentingCountrySelector) {
135+
NavigationStack {
136+
FilterListSelector(viewModel: viewModel.countrySelectorVM)
137+
.navigationBarTitleDisplayMode(.inline)
138+
.toolbar {
139+
ToolbarItem(placement: .confirmationAction) {
140+
Button {
141+
isPresentingCountrySelector = false
142+
} label: {
143+
Text(Localization.done)
144+
.bold()
145+
}
146+
}
147+
}
148+
}
149+
}
150+
.sheet(isPresented: $isPresentingStateSelector) {
151+
NavigationStack {
152+
FilterListSelector(viewModel: viewModel.stateSelectorVM)
153+
.navigationBarTitleDisplayMode(.inline)
154+
.toolbar {
155+
ToolbarItem(placement: .confirmationAction) {
156+
Button {
157+
isPresentingStateSelector = false
158+
} label: {
159+
Text(Localization.done)
160+
.bold()
161+
}
162+
}
163+
}
164+
}
165+
}
164166
.alert(
165167
viewModel.addressErrorState?.title ?? "",
166168
isPresented: $viewModel.isShowingAddressErrorAlert,

0 commit comments

Comments
 (0)