StoreStatsViewController: Updating Placeholder's Behavior

Author: jleandroperez

WooCommerce/Classes/ViewRelated/Dashboard/MyStore/PeriodDataViewController.swift

@@ -145,6 +145,12 @@ extension PeriodDataViewController {
 
 extension PeriodDataViewController {
 
+    /// Indicates if the receiver has Remote Stats, or not.
+    ///
+    var shouldDisplayGhostContent: Bool {
+        return orderStats == nil
+    }
+
     /// Displays the Placeholder Period Graph + Starts the Animation.
     /// Why is this public? Because the actual Sync OP is handled by StoreStatsViewController. We coordinate multiple
     /// placeholder animations from that spot!

WooCommerce/Classes/ViewRelated/Dashboard/MyStore/StoreStatsViewController.swift

@@ -69,7 +69,7 @@ extension StoreStatsViewController {
     func syncAllStats(onCompletion: (() -> Void)? = nil) {
         let group = DispatchGroup()
 
-        displayGhostContent()
+        ensureGhostContentIsDisplayed()
 
         periodVCs.forEach { (vc) in
             group.enter()
@@ -97,6 +97,16 @@ extension StoreStatsViewController {
 //
 private extension StoreStatsViewController {
 
+    /// Displays the Ghost Placeholder whenever there is no visible data.
+    ///
+    func ensureGhostContentIsDisplayed() {
+        guard visibleChildViewController.shouldDisplayGhostContent else {
+            return
+        }
+
+        displayGhostContent()
+    }
+
     /// Locks UI Interaction and displays Ghost Placeholder animations.
     ///
     func displayGhostContent() {