Crash fix for network changes while fetching info

joshheald · joshheald · commit b224cfdea63e · 2025-08-28T10:21:24.000+01:00
The continuation was being called twice, which could result in a crash.

Cancelling the network monitor before we resume should give us some resillience to this (but may not be a 100% fix).
diff --git a/WooCommerce/Classes/Tools/BackgroundTasks/BackgroundTaskRefreshDispatcher.swift b/WooCommerce/Classes/Tools/BackgroundTasks/BackgroundTaskRefreshDispatcher.swift
@@ -177,8 +177,8 @@ private struct BackgroundTaskSystemInfo {
             let monitor = NWPathMonitor()
 
             monitor.pathUpdateHandler = { path in
-                continuation.resume(returning: NetworkInfo(path: path))
                 monitor.cancel()
+                continuation.resume(returning: NetworkInfo(path: path))
             }
 
             let queue = DispatchQueue(label: "network.monitor.queue")

Original file line number	Diff line number	Diff line change
`@@ -177,8 +177,8 @@ private struct BackgroundTaskSystemInfo {`
`177`	`177`	`let monitor = NWPathMonitor()`
`178`	`178`
`179`	`179`	`monitor.pathUpdateHandler = { path in`
`180`		`- continuation.resume(returning: NetworkInfo(path: path))`
`181`	`180`	`monitor.cancel()`
	`181`	`+ continuation.resume(returning: NetworkInfo(path: path))`
`182`	`182`	`}`
`183`	`183`
`184`	`184`	`let queue = DispatchQueue(label: "network.monitor.queue")`