Empty bounds image view fallback to thumbnail size (#15815)

Author: RafaelKayumov

RELEASE-NOTES.txt

@@ -12,6 +12,7 @@
 - [internal] Reduced fields fetched for variations in Point of Sale [https://github.com/woocommerce/woocommerce-ios/pull/15712]
 - [*] Order List: Prevent last updated time being truncated at larger font sizes [https://github.com/woocommerce/woocommerce-ios/pull/15717]
 - [***] Creating shipping labels is now supported for stores with the WooCommerce Shipping extension [https://github.com/woocommerce/woocommerce-ios/pull/15738]
+- [internal] Optimized image handling with a fallback thumbnail size for image views that have empty bounds, preventing high memory usage. [https://github.com/woocommerce/woocommerce-ios/pull/15815]
 
 22.5
 -----

WooCommerce/Classes/Tools/ImageService/DefaultImageService.swift

@@ -59,7 +59,7 @@ struct DefaultImageService: ImageService {
         let targetSize: CGSize
         if ServiceLocator.featureFlagService.isFeatureFlagEnabled(
             .productImageOptimizedHandling
-        ) {
+        ) && !imageView.bounds.isEmpty {
             let scale = UIScreen.main.scale
             targetSize = CGSize(
                 width: imageView.bounds.width * scale,

WooCommerce/Classes/ViewRelated/Products/Cells/ProductsTabProductTableViewCell.swift

@@ -101,6 +101,9 @@ extension ProductsTabProductTableViewCell {
             productImageView.layer.borderWidth = 0
         } else {
             configureProductImageViewForBigImages()
+            /// Make sure `productImageView` is laid out and gained bounds
+            productImageView.layoutIfNeeded()
+
             productImageView.image = .productsTabProductCellPlaceholderImage
             if let productURLString = viewModel.imageUrl {
                 imageService.downloadAndCacheImageForImageView(productImageView,

WooCommerce/WooCommerceTests/Mocks/MockKingfisherImageDownloader.swift

@@ -5,6 +5,8 @@ final class MockKingfisherImageDownloader: Kingfisher.ImageDownloader {
     // Mocks in-memory cache.
     private let imagesByKey: [String: UIImage]
 
+    private(set) var capturedProcessor: ImageProcessor?
+
     init(imagesByKey: [String: UIImage]) {
         self.imagesByKey = imagesByKey
         super.init(name: "Mock!")
@@ -14,6 +16,14 @@ final class MockKingfisherImageDownloader: Kingfisher.ImageDownloader {
                                 options: KingfisherOptionsInfo? = nil,
                                 progressBlock: DownloadProgressBlock?,
                                 completionHandler: ((Result<ImageLoadingResult, KingfisherError>) -> Void)? = nil) -> DownloadTask? {
+        if let options = options {
+            for option in options {
+                if case .processor(let processor) = option {
+                    capturedProcessor = processor
+                    break
+                }
+            }
+        }
         if let image = imagesByKey[url.absoluteString] {
             completionHandler?(.success(.init(image: image, url: url, originalData: Data())))
         } else {
@@ -25,6 +35,7 @@ final class MockKingfisherImageDownloader: Kingfisher.ImageDownloader {
     override func downloadImage(with url: URL,
                                 options: KingfisherParsedOptionsInfo,
                                 completionHandler: ((Result<ImageLoadingResult, KingfisherError>) -> Void)? = nil) -> DownloadTask? {
+        capturedProcessor = options.processor
         if let image = imagesByKey[url.absoluteString] {
             completionHandler?(.success(.init(image: image, url: url, originalData: Data())))
         } else {

WooCommerce/WooCommerceTests/Tools/DefaultImageServiceTests.swift

@@ -265,4 +265,40 @@ final class DefaultImageServiceTests: XCTestCase {
 
         waitForExpectations(timeout: Constants.expectationTimeout, handler: nil)
     }
+
+    func testDownloadAndCacheImageForImageView_withEmptyBounds_usesDefaultThumbnailSize() {
+        // Given
+        let originalFeatureFlagService = ServiceLocator.featureFlagService
+        defer {
+            ServiceLocator.setFeatureFlagService(originalFeatureFlagService)
+        }
+
+        ServiceLocator.setFeatureFlagService(
+            MockFeatureFlagService(
+                isProductImageOptimizedHandlingEnabled: true
+            )
+        )
+
+        let mockImageView = UIImageView(frame: .zero)
+        let mockCache = MockImageCache(name: "Testing")
+        let mockDownloader = MockKingfisherImageDownloader(imagesByKey: [url.absoluteString: testImage])
+        imageService = DefaultImageService(imageCache: mockCache, imageDownloader: mockDownloader)
+
+        // When
+        imageService.downloadAndCacheImageForImageView(
+            mockImageView,
+            with: url.absoluteString,
+            placeholder: nil,
+            progressBlock: nil,
+            completion: nil
+        )
+
+        // Then
+        guard let downsamplingProcessor = mockDownloader.capturedProcessor as? DownsamplingImageProcessor else {
+            XCTFail("DownsamplingImageProcessor not found or not the correct type")
+            return
+        }
+
+        XCTAssertEqual(downsamplingProcessor.size, CGSize(width: 800, height: 800))
+    }
 }