Remove a task wrapper around refreshable to avoid cancelation

staskus · staskus · commit b9d209a5a975 · 2025-10-24T09:31:02.000+03:00
This hack was required to support child view changes while refresh is happening. However, we avoid changing the state now while refresh is happening so it's no longer necessary.
diff --git a/Modules/Sources/PointOfSale/Presentation/Item Selector/ChildItemList.swift b/Modules/Sources/PointOfSale/Presentation/Item Selector/ChildItemList.swift
@@ -78,9 +78,7 @@ private extension ChildItemList {
             .transition(.opacity)
             .refreshable {
                 analyticsTracker.trackRefresh()
-                await Task {
-                    await itemsController.refreshItems(base: node)
-                }.value
+                await itemsController.refreshItems(base: node)
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -78,9 +78,7 @@ private extension ChildItemList {`
`78`	`78`	`.transition(.opacity)`
`79`	`79`	`.refreshable {`
`80`	`80`	`analyticsTracker.trackRefresh()`
`81`		`- await Task {`
`82`		`- await itemsController.refreshItems(base: node)`
`83`		`- }.value`
	`81`	`+ await itemsController.refreshItems(base: node)`
`84`	`82`	`}`
`85`	`83`	`}`
`86`	`84`	`}`