Set appropriate search field placeholder

Author: staskus

WooCommerce/Classes/POS/Presentation/Item Search/POSProductSearchable.swift

@@ -4,7 +4,7 @@ import protocol Yosemite.POSSearchHistoryProviding
 import enum Yosemite.POSItem
 
 final class POSProductSearchable: POSSearchable {
-    let itemListType: ItemListType
+    private let itemListType: ItemListType
     private let itemsController: PointOfSaleSearchingItemsControllerProtocol
     private let searchHistoryProvider: POSSearchHistoryProviding
 
@@ -20,6 +20,10 @@ final class POSProductSearchable: POSSearchable {
         searchHistoryProvider.searchHistory(for: itemListType.itemType)
     }
 
+    var searchFieldPlaceholder: String {
+        itemListType.itemType.searchFieldLabel
+    }
+
     func performSearch(term: String) async {
         await itemsController.searchItems(searchTerm: term, baseItem: .root)
     }

WooCommerce/Classes/POS/Presentation/Item Search/POSSearchView.swift

@@ -4,9 +4,7 @@ import enum Yosemite.POSItem
 
 /// Protocol defining search capabilities for POS items
 protocol POSSearchable {
-    /// The type of item lists being searched
-    var itemListType: ItemListType { get }
-
+    var searchFieldPlaceholder: String { get }
     /// Recent search history for the current item type
     var searchHistory: [String] { get }
 
@@ -47,7 +45,7 @@ struct POSSearchField: View {
             }))
 
             TextField(text: $searchTerm) {
-                Text(searchable.itemListType.itemType.searchFieldLabel)
+                Text(searchable.searchFieldPlaceholder)
             }
             .textFieldStyle(POSSearchTextFieldStyle(focused: isSearchFieldFocused,
                                                     searchTerm: $searchTerm))
@@ -107,13 +105,16 @@ struct POSSearchContentView<Content: View>: View {
     @Environment(\.dynamicTypeSize) private var dynamicTypeSize
 
     private let searchable: any POSSearchable
+    private let itemListType: ItemListType
     @Binding private var searchTerm: String
     private let content: (Bool) -> Content
 
     init(searchable: any POSSearchable,
+         itemListType: ItemListType,
          searchTerm: Binding<String>,
          @ViewBuilder content: @escaping (Bool) -> Content) {
         self.searchable = searchable
+        self.itemListType = itemListType
         self._searchTerm = searchTerm
         self.content = content
     }
@@ -134,15 +135,15 @@ struct POSSearchContentView<Content: View>: View {
                          onSearchSelected: { selectedSearchTerm in
             searchTerm = selectedSearchTerm
             ServiceLocator.analytics.track(
-                event: .PointOfSale.preSearchRecentTermTapped(itemListType: searchable.itemListType))
+                event: .PointOfSale.preSearchRecentTermTapped(itemListType: itemListType))
         },
-                         itemListType: searchable.itemListType
+                         itemListType: itemListType
         )
     }
 }
 
 // MARK: - Localization
-private extension POSItemType {
+extension POSItemType {
     var searchFieldLabel: String {
         switch self {
         case .product:

WooCommerce/Classes/POS/Presentation/ItemListView.swift

@@ -128,6 +128,7 @@ struct ItemListView: View {
                     searchable: POSProductSearchable(itemListType: selectedItemListType,
                                                      itemsController: searchItemsController,
                                                      searchHistoryProvider: posModel.searchHistoryService),
+                    itemListType: selectedItemListType,
                     searchTerm: $searchTerm
                 ) { _ in
                     itemListContent(selectedItemListType)

WooCommerce/Classes/POS/Presentation/Orders/PointOfSaleOrderListView.swift

@@ -333,14 +333,14 @@ private extension PointOfSaleOrderListView {
 final class POSOrderSearchable: POSSearchable {
     private let ordersController: PointOfSaleSearchingOrderListControllerProtocol
 
-    var itemListType: ItemListType {
-        .products(search: false)
-    }
-
     init(ordersController: PointOfSaleSearchingOrderListControllerProtocol) {
         self.ordersController = ordersController
     }
 
+    var searchFieldPlaceholder: String {
+        Localization.searchFieldPlaceholder
+    }
+
     var searchHistory: [String] {
         []
     }
@@ -368,6 +368,12 @@ private enum Localization {
         "pos.orderListView.ordersTitle",
         value: "Orders",
         comment: "Title at the header for the Orders view.")
+
+    static let searchFieldPlaceholder = NSLocalizedString(
+        "pos.orderListView.searchFieldPlaceholder",
+        value: "Search orders",
+        comment: "Placeholder for a search field in the Orders view."
+    )
 }
 
 #if DEBUG