Remove unnecessary iOS 17 checks now that the app is iOS 17+ and unused POSIneligibleReason cases.

Author: jaclync

WooCommerce/Classes/POS/Analytics/WooAnalyticsEvent+PointOfSaleIneligibleUI.swift

@@ -26,10 +26,6 @@ private extension POSIneligibleReason {
             return "feature_switch_disabled"
         case .wooCommercePluginNotFound:
             return "unknown_wc_plugin"
-        case .unsupportedIOSVersion:
-            return "ios_version"
-        case .unsupportedInCIABSites:
-            return "feature_unsupported_in_ciab"
         case .siteSettingsNotAvailable,
              .selfDeallocated:
             return "other"

WooCommerce/Classes/POS/Models/POSIneligibleReason.swift

@@ -4,14 +4,12 @@ import enum WooFoundation.CurrencyCode
 
 /// Represents the reasons why a site may be ineligible for POS.
 enum POSIneligibleReason: Equatable {
-    case unsupportedIOSVersion
     case unsupportedWooCommerceVersion(minimumVersion: String)
     case siteSettingsNotAvailable
     case wooCommercePluginNotFound
     case featureSwitchDisabled
     case unsupportedCurrency(countryCode: CountryCode, supportedCurrencies: [CurrencyCode])
     case selfDeallocated
-    case unsupportedInCIABSites
 }
 
 /// Represents the eligibility state for POS.

WooCommerce/Classes/POS/TabBar/POSIneligibleView.swift

@@ -112,10 +112,6 @@ struct POSIneligibleView: View {
 
     private var suggestionText: String {
         switch reason {
-        case .unsupportedIOSVersion:
-            return NSLocalizedString("pos.ineligible.suggestion.unsupportedIOSVersion.1",
-                                     value: "The POS system requires iOS 17 or later. Please update your device to iOS 17+ to use this feature.",
-                                     comment: "Suggestion for unsupported iOS version: update iOS")
         case let .unsupportedWooCommerceVersion(minimumVersion):
             let format = NSLocalizedString("pos.ineligible.suggestion.unsupportedWooCommerceVersion",
                                      value: "Your WooCommerce version is not supported. " +
@@ -155,12 +151,6 @@ struct POSIneligibleView: View {
             return NSLocalizedString("pos.ineligible.suggestion.selfDeallocated",
                                      value: "Try relaunching the app to resolve this issue.",
                                      comment: "Suggestion for self deallocated: relaunch")
-        case .unsupportedInCIABSites:
-            return NSLocalizedString(
-                "pos.ineligible.suggestion.notSupportedForCIAB",
-                value: "The POS system is not supported for your store.",
-                comment: "Suggestion for CIAB sites: feature is not supported"
-            )
         }
     }
 }
@@ -184,9 +174,6 @@ private extension POSIneligibleView {
 private extension POSIneligibleReason {
     var shouldShowRetryButton: Bool {
         switch self {
-        case .unsupportedIOSVersion,
-                .unsupportedInCIABSites:
-            return false
         case .unsupportedWooCommerceVersion,
                 .siteSettingsNotAvailable,
                 .wooCommercePluginNotFound,
@@ -205,8 +192,7 @@ private extension POSIneligibleReason {
                 value: "Enable POS feature",
                 comment: "Button title to enable the POS feature switch and refresh POS eligibility check"
             )
-        case .unsupportedIOSVersion,
-                .unsupportedWooCommerceVersion,
+        case .unsupportedWooCommerceVersion,
                 .siteSettingsNotAvailable,
                 .wooCommercePluginNotFound,
                 .unsupportedCurrency,
@@ -216,9 +202,6 @@ private extension POSIneligibleReason {
                 value: "Retry",
                 comment: "Button title to refresh POS eligibility check"
             )
-        case .unsupportedInCIABSites:
-            assertionFailure("Retry button should not be shown for `unsupportedInCIABSites`")
-            return String()
         }
     }
 }
@@ -234,15 +217,6 @@ private extension POSIneligibleReason {
     }
 }
 
-#Preview("Unsupported iOS version") {
-    if #available(iOS 17.0, *) {
-        POSIneligibleView(
-            reason: .unsupportedIOSVersion,
-            onRefresh: {}
-        )
-    }
-}
-
 #Preview("WooCommerce plugin not found") {
     if #available(iOS 17.0, *) {
         POSIneligibleView(

WooCommerce/Classes/ViewRelated/Dashboard/Settings/POS/POSTabEligibilityChecker.swift

@@ -54,10 +54,6 @@ final class POSTabEligibilityChecker: POSEntryPointEligibilityCheckerProtocol {
 
     /// Determines whether the POS entry point can be shown based on the selected store and feature gates.
     func checkEligibility() async -> POSEligibilityState {
-        guard #available(iOS 17.0, *) else {
-            return .ineligible(reason: .unsupportedIOSVersion)
-        }
-
         async let siteSettingsEligibility = checkSiteSettingsEligibility()
         async let pluginEligibility = checkPluginEligibility()
 
@@ -78,11 +74,6 @@ final class POSTabEligibilityChecker: POSEntryPointEligibilityCheckerProtocol {
 
     func refreshEligibility(ineligibleReason: POSIneligibleReason) async throws -> POSEligibilityState {
         switch ineligibleReason {
-        case .unsupportedIOSVersion:
-            // TODO: WOOMOB-768 - hide refresh CTA in this case
-            return .ineligible(reason: .unsupportedIOSVersion)
-        case .unsupportedInCIABSites:
-            return .ineligible(reason: .unsupportedInCIABSites)
         case .siteSettingsNotAvailable, .unsupportedCurrency:
             do {
                 try await syncSiteSettingsRemotely()

WooCommerce/WooCommerceTests/POS/Controllers/POSEntryPointControllerTests.swift

@@ -5,7 +5,7 @@ struct POSEntryPointControllerTests {
     @Test func eligibilityState_is_set_to_ineligible_when_checker_returns_ineligible() async throws {
         // Given
         let mockEligibilityChecker = MockPOSEligibilityChecker()
-        let expectedState = POSEligibilityState.ineligible(reason: .unsupportedIOSVersion)
+        let expectedState = POSEligibilityState.ineligible(reason: .featureSwitchDisabled)
         mockEligibilityChecker.eligibility = expectedState
 
         // When

WooCommerce/WooCommerceTests/POS/Models/PointOfSaleAggregateModelTests.swift

@@ -966,7 +966,6 @@ private func makeLoadedOrderState(cartTotal: String = "",
     )
 }
 
-@available(iOS 17.0, *)
 private func makePointOfSaleAggregateModel(
     entryPointController: POSEntryPointController = POSEntryPointController(eligibilityChecker: MockPOSEligibilityChecker()),
     itemsController: PointOfSaleItemsControllerProtocol = MockPointOfSaleItemsController(),

WooCommerce/WooCommerceTests/POS/Presentation/POSItemActionHandlerTests.swift

@@ -97,7 +97,6 @@ private func makeProductItem() -> POSItem {
                                 stockStatusKey: ""))
 }
 
-@available(iOS 17.0, *)
 private func makePointOfSaleAggregateModel(
     entryPointController: POSEntryPointController = POSEntryPointController(eligibilityChecker: MockPOSEligibilityChecker()),
     itemsController: PointOfSaleItemsControllerProtocol = MockPointOfSaleItemsController(),

WooCommerce/WooCommerceTests/POS/ViewHelpers/PointOfSaleDashboardViewHelperTests.swift

@@ -61,7 +61,6 @@ struct PointOfSaleDashboardViewHelperTests {
     }
 
     @Test(arguments: [
-        POSIneligibleReason.unsupportedIOSVersion,
         POSIneligibleReason.unsupportedWooCommerceVersion(minimumVersion: "9.6.0"),
         POSIneligibleReason.unsupportedCurrency(countryCode: .US, supportedCurrencies: [.USD, .GBP]),
         POSIneligibleReason.siteSettingsNotAvailable,
@@ -156,7 +155,7 @@ struct PointOfSaleDashboardViewHelperTests {
 
     @Test func determineViewState_horizontalSizeClass_takes_priority_over_eligibility_state() async throws {
         // Given - compact size class should return unsupportedWidth regardless of eligibility
-        let eligibilityState: POSEligibilityState = .ineligible(reason: .unsupportedIOSVersion)
+        let eligibilityState: POSEligibilityState = .ineligible(reason: .featureSwitchDisabled)
         let itemsContainerState: ItemsContainerState = .content
         let horizontalSizeClass: UserInterfaceSizeClass = .compact
 
@@ -190,7 +189,7 @@ struct PointOfSaleDashboardViewHelperTests {
 
     @Test func determineViewState_ineligible_state_takes_priority_over_containerState() async throws {
         // Given - ineligible state should return ineligible regardless of container state
-        let eligibilityState: POSEligibilityState = .ineligible(reason: .unsupportedIOSVersion)
+        let eligibilityState: POSEligibilityState = .ineligible(reason: .featureSwitchDisabled)
         let itemsContainerState: ItemsContainerState = .content
         let horizontalSizeClass: UserInterfaceSizeClass = .regular
 
@@ -202,7 +201,7 @@ struct PointOfSaleDashboardViewHelperTests {
         )
 
         // Then
-        #expect(result == .ineligible(reason: .unsupportedIOSVersion))
+        #expect(result == .ineligible(reason: .featureSwitchDisabled))
     }
 
     // MARK: - Floating Control Tests
@@ -219,7 +218,7 @@ struct PointOfSaleDashboardViewHelperTests {
 
     @Test(arguments: [
         (PointOfSaleDashboardView.ViewState.loading, false),
-        (PointOfSaleDashboardView.ViewState.ineligible(reason: .unsupportedIOSVersion), false)
+        (PointOfSaleDashboardView.ViewState.ineligible(reason: .featureSwitchDisabled), false)
     ])
     func showsFloatingControl_when_loading_or_ineligible_returns_false(viewState: PointOfSaleDashboardView.ViewState, expected: Bool) async throws {
         // When & Then

WooCommerce/WooCommerceTests/ViewRelated/Settings/POS/POSTabEligibilityCheckerTests.swift

@@ -220,19 +220,6 @@ struct POSTabEligibilityCheckerTests {
 
     // MARK: - `refreshEligibility` Tests
 
-    @Test func refreshEligibility_returns_ineligible_for_unsupportedIOSVersion() async throws {
-        // Given
-        let checker = POSTabEligibilityChecker(siteID: siteID,
-                                               siteSettings: siteSettings,
-                                               stores: stores)
-
-        // When
-        let result = try await checker.refreshEligibility(ineligibleReason: .unsupportedIOSVersion)
-
-        // Then
-        #expect(result == .ineligible(reason: .unsupportedIOSVersion))
-    }
-
     @Test(arguments: [
         POSIneligibleReason.siteSettingsNotAvailable,
         POSIneligibleReason.unsupportedCurrency(countryCode: .US, supportedCurrencies: [.USD])