Skip to content

Commit c66416d

Browse files
Use authentication token directly instead of Credentials to simplify unit tests.
1 parent 7ccf5a4 commit c66416d

File tree

1 file changed

+5
-22
lines changed

1 file changed

+5
-22
lines changed

Networking/NetworkingTests/Requests/AuthenticatedDotcomRequestTests.swift

Lines changed: 5 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ final class AuthenticatedDotcomRequestTests: XCTestCase {
1111
///
1212
private var unauthenticatedRequest: URLRequest!
1313

14-
/// Sample Credentials
14+
/// Sample Auth Token
1515
///
16-
private let credentials = Credentials(username: "username", authToken: "yosemite", siteAddress: "https://wordpress.com")
16+
private let authToken = "yosemite"
1717

1818
override func setUp() {
1919
super.setUp()
@@ -33,14 +33,8 @@ final class AuthenticatedDotcomRequestTests: XCTestCase {
3333
// Given
3434
XCTAssertEqual(unauthenticatedRequest.allHTTPHeaderFields, [:])
3535

36-
guard case let .wpcom(_, authToken, _) = credentials else {
37-
XCTFail("Missing credentials.")
38-
return
39-
}
40-
41-
let authenticated = AuthenticatedDotcomRequest(authToken: authToken, request: unauthenticatedRequest)
42-
4336
// When
37+
let authenticated = AuthenticatedDotcomRequest(authToken: authToken, request: unauthenticatedRequest)
4438
let output = authenticated.asURLRequest()
4539

4640
// Then
@@ -55,14 +49,9 @@ final class AuthenticatedDotcomRequestTests: XCTestCase {
5549
// Given
5650
XCTAssertEqual(unauthenticatedRequest.allHTTPHeaderFields, [:])
5751

58-
guard case let .wpcom(_, authToken, _) = credentials else {
59-
XCTFail("Missing credentials.")
60-
return
61-
}
62-
63-
let authenticated = AuthenticatedDotcomRequest(authToken: authToken, request: unauthenticatedRequest)
6452

6553
// When
54+
let authenticated = AuthenticatedDotcomRequest(authToken: authToken, request: unauthenticatedRequest)
6655
let output = authenticated.asURLRequest()
6756

6857
// Then
@@ -76,14 +65,8 @@ final class AuthenticatedDotcomRequestTests: XCTestCase {
7665
// Given
7766
XCTAssertEqual(unauthenticatedRequest.allHTTPHeaderFields, [:])
7867

79-
guard case let .wpcom(_, authToken, _) = credentials else {
80-
XCTFail("Missing credentials.")
81-
return
82-
}
83-
84-
let authenticated = AuthenticatedDotcomRequest(authToken: authToken, request: unauthenticatedRequest)
85-
8668
// When
69+
let authenticated = AuthenticatedDotcomRequest(authToken: authToken, request: unauthenticatedRequest)
8770
let output = authenticated.asURLRequest()
8871

8972
// Then

0 commit comments

Comments
 (0)