Revert RequirementsChecker.baseViewController visibility

Author: adborbas

WooCommerce/Classes/AppDelegate.swift

@@ -40,7 +40,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
     ///
     private var jetpackSetupCoordinator: JetpackSetupCoordinator?
 
-    private(set) var requirementsChecker = RequirementsChecker(baseViewController: nil)
+    private(set) lazy var requirementsChecker = RequirementsChecker(baseViewController: tabBarController)
 
     /// Handles events to background refresh the app.
     ///
@@ -111,20 +111,6 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
         return true
     }
 
-    func application(_ app: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey: Any] = [:]) -> Bool {
-        guard let sceneDelegate = UIApplication.sceneDelegate,
-              let rootViewController = sceneDelegate.window?.rootViewController else {
-            fatalError()
-        }
-
-        if let universalLinkRouter = sceneDelegate.universalLinkRouter, universalLinkRouter.canHandle(url: url) {
-            universalLinkRouter.handle(url: url)
-            return true
-        }
-
-        return handleAuthenticationUrl(url, options: options, rootViewController: rootViewController)
-    }
-
     func application(_ application: UIApplication, didRegisterForRemoteNotificationsWithDeviceToken deviceToken: Data) {
         guard let defaultStoreID = ServiceLocator.stores.sessionManager.defaultStoreID else {
             return
@@ -262,7 +248,6 @@ extension AppDelegate {
 
     /// Push Notifications: Authorization + Registration!
     ///
-    /// periphery: ignore - Fails when build on simulator
     func setupPushNotificationsManagerIfPossible(_ pushNotesManager: PushNotesManager, stores: StoresManager) {
         #if targetEnvironment(simulator)
             DDLogVerbose("👀 Push Notifications are not supported in the Simulator!")

WooCommerce/Classes/SceneDelegate.swift

@@ -38,9 +38,6 @@ final class SceneDelegate: UIResponder, UIWindowSceneDelegate {
             handle(shortcutItem: shortcut, completion: nil)
         }
 
-        // Update AppDelegate-scoped dependencies that rely on a base VC
-        AppDelegate.shared.requirementsChecker.baseViewController = tabBarController
-
         // Take advantage of a bug in UIAlertController to style all UIAlertControllers with WC color
         UIApplication.wooKeyWindow?.tintColor = .primary
     }

WooCommerce/Classes/Tools/RequirementsChecker.swift

@@ -25,7 +25,7 @@ enum RequirementCheckResult: Int, CaseIterable {
 final class RequirementsChecker {
 
     private let stores: StoresManager
-    var baseViewController: UIViewController?
+    private let baseViewController: UIViewController?
 
     init(stores: StoresManager = ServiceLocator.stores,
          baseViewController: UIViewController? = nil) {