Merge pull request #8302 from woocommerce/task/remove-upsell-card-readers-settings-leftovers

[Moooore IPP]Remove upsell card readers settings leftovers.

Author: toupper

WooCommerce/Classes/ViewRelated/Dashboard/Settings/Settings/SettingsViewController.swift

@@ -134,8 +134,6 @@ private extension SettingsViewController {
             configurePlugins(cell: cell)
         case let cell as HostingTableViewCell<PluginDetailsRowView> where row == .woocommerceDetails:
             configureWooCommmerceDetails(cell: cell)
-        case let cell as HostingTableViewCell<FeatureAnnouncementCardView> where row == .upsellCardReadersFeatureAnnouncement:
-            configureUpsellCardReadersFeatureAnnouncement(cell: cell)
         case let cell as BasicTableViewCell where row == .installJetpack:
             configureInstallJetpack(cell: cell)
         case let cell as BasicTableViewCell where row == .support:
@@ -191,15 +189,6 @@ private extension SettingsViewController {
         cell.textLabel?.text = Localization.helpAndSupport
     }
 
-    func configureUpsellCardReadersFeatureAnnouncement(cell: HostingTableViewCell<FeatureAnnouncementCardView>) {
-        let view = FeatureAnnouncementCardView(viewModel: viewModel.upsellCardReadersAnnouncementViewModel,
-                                               dismiss: { [weak self] in
-            self?.viewModel.reloadSettings()
-        })
-        cell.host(view, parent: self)
-        cell.selectionStyle = .none
-    }
-
     func configureInstallJetpack(cell: BasicTableViewCell) {
         cell.accessoryType = .disclosureIndicator
         cell.selectionStyle = .default
@@ -601,7 +590,6 @@ extension SettingsViewController {
         case woocommerceDetails
 
         // Store settings
-        case upsellCardReadersFeatureAnnouncement
         case installJetpack
 
         // Help & Feedback
@@ -628,7 +616,7 @@ extension SettingsViewController {
 
         fileprivate var registerWithNib: Bool {
             switch self {
-            case .upsellCardReadersFeatureAnnouncement, .woocommerceDetails:
+            case .woocommerceDetails:
                 return false
             default:
                 return true
@@ -647,8 +635,6 @@ extension SettingsViewController {
                 return HostingTableViewCell<PluginDetailsRowView>.self
             case .support:
                 return BasicTableViewCell.self
-            case .upsellCardReadersFeatureAnnouncement:
-                return HostingTableViewCell<FeatureAnnouncementCardView>.self
             case .installJetpack:
                 return BasicTableViewCell.self
             case .logout, .closeAccount:

WooCommerce/Classes/ViewRelated/Dashboard/Settings/Settings/SettingsViewModel.swift

@@ -50,7 +50,6 @@ protocol SettingsViewModelActionsHandler {
 
 protocol SettingsViewModelInput: AnyObject {
     var presenter: SettingsViewPresenter? { get set }
-    var upsellCardReadersAnnouncementViewModel: FeatureAnnouncementCardViewModel { get }
 }
 
 final class SettingsViewModel: SettingsViewModelOutput, SettingsViewModelActionsHandler, SettingsViewModelInput {
@@ -103,12 +102,6 @@ final class SettingsViewModel: SettingsViewModelOutput, SettingsViewModelActions
     private let storageManager: StorageManagerType
     private let featureFlagService: FeatureFlagService
     private let appleIDCredentialChecker: AppleIDCredentialCheckerProtocol
-    private let upsellCardReadersCampaign = UpsellCardReadersCampaign(source: .settings)
-
-    var upsellCardReadersAnnouncementViewModel: FeatureAnnouncementCardViewModel {
-        .init(analytics: ServiceLocator.analytics,
-              configuration: upsellCardReadersCampaign.configuration)
-    }
 
     /// Reference to the Zendesk shared instance
     ///