Merge pull request #1858 from woocommerce/fix/orders-badge-not-refreshed-when-the-count-is-zero

Hotfix: fixed orders badge count when you switch between two stores (one with badge count = 0)

Author: pmusolino

RELEASE-NOTES.txt

@@ -8,6 +8,7 @@
 - Orders tab: The full total amount is now shown.
 - Order Details & Product UI: if a Product name has HTML escape characters, they should be decoded in the app.
 - Order Details: if the Order has multiple Products, tapping on any Product should open the same Product now.
+- bugfix: the orders badge on tab bar now is correctly refreshed after switching to a store with badge count equal to zero.
 
 3.5
 -----

WooCommerce/Classes/ViewRelated/MainTabBarController.swift

@@ -390,8 +390,7 @@ private extension MainTabBarController {
 private extension MainTabBarController {
     func startListeningToOrdersBadge() {
         viewModel.onBadgeReload = { [weak self] countReadableString in
-            guard let self = self,
-            let badgeText = countReadableString else {
+            guard let self = self else {
                 return
             }
 
@@ -402,7 +401,7 @@ private extension MainTabBarController {
                 return
             }
 
-            orderTab.badgeValue = badgeText
+            orderTab.badgeValue = countReadableString
             orderTab.badgeColor = .primary
         }