make mock and wrap preview in debug flag

Author: iamgabrielma

WooCommerce/Classes/POS/Models/PointOfSaleSettingsController.swift

@@ -22,25 +22,6 @@ protocol PointOfSaleSettingsControllerProtocol {
     func retrievePOSReceiptSettings() async
 }
 
-class PointOfSaleSettingsPreviewController: PointOfSaleSettingsControllerProtocol {
-    var receiptStoreName: String? = "Sample Store"
-    var receiptStoreAddress: String? = "123 Main Street\nAnytown, ST 12345"
-    var receiptStorePhone: String? = "+1 (555) 123-4567"
-    var receiptStoreEmail: String? = "[email protected]"
-    var receiptRefundReturnsPolicy: String? = "30-day return policy"
-    var isLoading: Bool = false
-    var shouldShowReceiptInformation: Bool = true
-    var storeName: String = "Sample Store"
-
-    var storeAddress: String {
-        "123 Main Street\nAnytown, ST 12345"
-    }
-
-    func retrievePOSReceiptSettings() async {
-        // no-op
-    }
-}
-
 @Observable final class PointOfSaleSettingsController: PointOfSaleSettingsControllerProtocol {
     private(set) var receiptStoreName: String?
     private(set) var receiptStoreAddress: String?
@@ -135,3 +116,24 @@ private extension PointOfSaleSettingsController {
         )
     }
 }
+
+#if DEBUG
+final class PointOfSaleSettingsPreviewController: PointOfSaleSettingsControllerProtocol {
+    var receiptStoreName: String? = "Sample Store"
+    var receiptStoreAddress: String? = "123 Main Street\nAnytown, ST 12345"
+    var receiptStorePhone: String? = "+1 (555) 123-4567"
+    var receiptStoreEmail: String? = "[email protected]"
+    var receiptRefundReturnsPolicy: String? = "30-day return policy"
+    var isLoading: Bool = false
+    var shouldShowReceiptInformation: Bool = true
+    var storeName: String = "Sample Store"
+
+    var storeAddress: String {
+        "123 Main Street\nAnytown, ST 12345"
+    }
+
+    func retrievePOSReceiptSettings() async {
+        // no-op
+    }
+}
+#endif

WooCommerce/Classes/POS/Presentation/Settings/PointOfSaleSettingsView.swift

@@ -178,6 +178,8 @@ private extension PointOfSaleSettingsView {
     }
 }
 
+#if DEBUG
 #Preview {
     PointOfSaleSettingsView(settingsController: PointOfSaleSettingsPreviewController())
 }
+#endif

WooCommerce/WooCommerceTests/POS/Controllers/PointOfSaleSettingsControllerTests.swift

@@ -90,3 +90,22 @@ private final class MockPointOfSaleSettingsService: PointOfSaleSettingsServicePr
         }
     }
 }
+
+final class MockPointOfSaleSettingsController: PointOfSaleSettingsControllerProtocol {
+    var receiptStoreName: String? = "Sample Store"
+    var receiptStoreAddress: String? = "123 Main Street\nAnytown, ST 12345"
+    var receiptStorePhone: String? = "+1 (555) 123-4567"
+    var receiptStoreEmail: String? = "[email protected]"
+    var receiptRefundReturnsPolicy: String? = "30-day return policy"
+    var isLoading: Bool = false
+    var shouldShowReceiptInformation: Bool = true
+    var storeName: String = "Sample Store"
+
+    var storeAddress: String {
+        "123 Main Street\nAnytown, ST 12345"
+    }
+
+    func retrievePOSReceiptSettings() async {
+        // no-op
+    }
+}

WooCommerce/WooCommerceTests/POS/Models/PointOfSaleAggregateModelTests.swift

@@ -967,7 +967,7 @@ private func makePointOfSaleAggregateModel(
     couponsSearchController: PointOfSaleSearchingItemsControllerProtocol = MockPointOfSaleCouponsController(),
     cardPresentPaymentService: CardPresentPaymentFacade = MockCardPresentPaymentService(),
     orderController: PointOfSaleOrderControllerProtocol = MockPointOfSaleOrderController(),
-    settingsController: PointOfSaleSettingsControllerProtocol = PointOfSaleSettingsPreviewController(),
+    settingsController: PointOfSaleSettingsControllerProtocol = MockPointOfSaleSettingsController(),
     analytics: Analytics = WooAnalytics(analyticsProvider: MockAnalyticsProvider()),
     collectOrderPaymentAnalyticsTracker: POSCollectOrderPaymentAnalyticsTracking = MockPOSCollectOrderPaymentAnalyticsTracker(),
     searchHistoryService: POSSearchHistoryProviding = MockPOSSearchHistoryService(),

WooCommerce/WooCommerceTests/POS/Presentation/POSItemActionHandlerTests.swift

@@ -101,7 +101,7 @@ private func makePointOfSaleAggregateModel(
     couponsSearchController: PointOfSaleSearchingItemsControllerProtocol = MockPointOfSaleCouponsController(),
     cardPresentPaymentService: CardPresentPaymentFacade = MockCardPresentPaymentService(),
     orderController: PointOfSaleOrderControllerProtocol = MockPointOfSaleOrderController(),
-    settingsController: PointOfSaleSettingsControllerProtocol = PointOfSaleSettingsPreviewController(),
+    settingsController: PointOfSaleSettingsControllerProtocol = MockPointOfSaleSettingsController(),
     collectOrderPaymentAnalyticsTracker: POSCollectOrderPaymentAnalyticsTracking = MockPOSCollectOrderPaymentAnalyticsTracker(),
     searchHistoryService: POSSearchHistoryProviding = MockPOSSearchHistoryService(),
     popularPurchasableItemsController: PointOfSaleItemsControllerProtocol = MockPointOfSaleItemsController(),