Fix warning about offline banner on dashboard (#16347)

Author: itsmeichigo

RELEASE-NOTES.txt

@@ -9,6 +9,7 @@
 - [*] Fix order details presentation when opened from booking details [https://github.com/woocommerce/woocommerce-ios/pull/16331]
 - [*] Show POS feedback surveys for eligible merchants [https://github.com/woocommerce/woocommerce-ios/pull/16325]
 - [*] Fix product variation selection for order creation [https://github.com/woocommerce/woocommerce-ios/pull/16317]
+- [Internal] Fix warning when displaying offline banner on My Store [https://github.com/woocommerce/woocommerce-ios/pull/16347]
 - [Internal] Notify listeners immediately after updating predicates or sort descriptors for results controllers. [https://github.com/woocommerce/woocommerce-ios/pull/16350]
 
 23.6

WooCommerce/Classes/ViewRelated/Dashboard/DashboardView.swift

@@ -162,6 +162,10 @@ struct DashboardView: View {
 
             storePlanBanner
                 .renderedIf(connectivityStatus != .notReachable)
+
+            OfflineBannerViewRepresentable()
+                .frame(height: OfflineBannerView.height)
+                .renderedIf(connectivityStatus == .notReachable)
         }
         .sheet(isPresented: $showingSupportForm) {
             supportForm

WooCommerce/Classes/ViewRelated/Dashboard/DashboardViewHostingController.swift

@@ -75,10 +75,6 @@ final class DashboardViewHostingController: UIHostingController<DashboardView> {
             await viewModel.reloadAllData()
         }
     }
-
-    override var shouldShowOfflineBanner: Bool {
-        return true
-    }
 }
 
 // MARK: Private helpers