[Woo POS][Local Catalog] Tests for saving pos models (#16064)

joshheald · web-flow · commit d0c1b2d7a0ea · 2025-09-01T14:00:47.000+01:00
diff --git a/Modules/Sources/Storage/GRDB/Model/PersistedProduct.swift b/Modules/Sources/Storage/GRDB/Model/PersistedProduct.swift
@@ -1,6 +1,7 @@
 import Foundation
 import GRDB
 
+// periphery:ignore - TODO: remove ignore when populating database
 public struct PersistedProduct: Codable {
     public let id: Int64
     public let siteID: Int64
@@ -48,6 +49,7 @@ public struct PersistedProduct: Codable {
     }
 }
 
+// periphery:ignore - TODO: remove ignore when populating database
 extension PersistedProduct: FetchableRecord, PersistableRecord {
     public static var databaseTableName: String { "product" }
 
@@ -72,6 +74,7 @@ extension PersistedProduct: FetchableRecord, PersistableRecord {
     public static let attributes = hasMany(PersistedProductAttribute.self)
 }
 
+// periphery:ignore - TODO: remove ignore when populating database
 private extension PersistedProduct {
     enum CodingKeys: String, CodingKey {
         case id
diff --git a/Modules/Sources/Storage/GRDB/Model/PersistedProductAttribute.swift b/Modules/Sources/Storage/GRDB/Model/PersistedProductAttribute.swift
@@ -1,6 +1,7 @@
 import Foundation
 import GRDB
 
+// periphery:ignore - TODO: remove ignore when populating database
 public struct PersistedProductAttribute: Codable {
     public private(set) var id: Int64?
     public let productID: Int64
@@ -27,6 +28,7 @@ public struct PersistedProductAttribute: Codable {
     }
 }
 
+// periphery:ignore - TODO: remove ignore when populating database
 extension PersistedProductAttribute: FetchableRecord, MutablePersistableRecord {
     public static var databaseTableName: String { "productAttribute" }
 
@@ -46,6 +48,7 @@ extension PersistedProductAttribute: FetchableRecord, MutablePersistableRecord {
 }
 
 
+// periphery:ignore - TODO: remove ignore when populating database
 private extension PersistedProductAttribute {
     enum CodingKeys: String, CodingKey {
         case id
diff --git a/Modules/Sources/Storage/GRDB/Model/PersistedProductImage.swift b/Modules/Sources/Storage/GRDB/Model/PersistedProductImage.swift
@@ -1,6 +1,7 @@
 import Foundation
 import GRDB
 
+// periphery:ignore - TODO: remove ignore when populating database
 public struct PersistedProductImage: Codable {
     public let id: Int64
     public let productID: Int64
@@ -27,6 +28,7 @@ public struct PersistedProductImage: Codable {
     }
 }
 
+// periphery:ignore - TODO: remove ignore when populating database
 extension PersistedProductImage: FetchableRecord, PersistableRecord {
     public static var databaseTableName: String { "productImage" }
 
@@ -42,6 +44,7 @@ extension PersistedProductImage: FetchableRecord, PersistableRecord {
 }
 
 
+// periphery:ignore - TODO: remove ignore when populating database
 private extension PersistedProductImage {
     enum CodingKeys: String, CodingKey {
         case id
diff --git a/Modules/Sources/Storage/GRDB/Model/PersistedProductVariation.swift b/Modules/Sources/Storage/GRDB/Model/PersistedProductVariation.swift
@@ -1,6 +1,7 @@
 import Foundation
 import GRDB
 
+// periphery:ignore - TODO: remove ignore when populating database
 public struct PersistedProductVariation: Codable {
     public let id: Int64
     public let siteID: Int64
@@ -39,6 +40,7 @@ public struct PersistedProductVariation: Codable {
     }
 }
 
+// periphery:ignore - TODO: remove ignore when populating database
 extension PersistedProductVariation: FetchableRecord, PersistableRecord {
     public static var databaseTableName: String { "productVariation" }
 
@@ -56,11 +58,12 @@ extension PersistedProductVariation: FetchableRecord, PersistableRecord {
         static let stockStatusKey = Column(CodingKeys.stockStatusKey)
     }
 
-    public static let attributes = hasMany(PersistedProductVariationAttribute.self)
-    public static let image = hasOne(PersistedProductVariationImage.self)
+    public static let attributes = hasMany(PersistedProductVariationAttribute.self).forKey("attributes")
+    public static let image = hasOne(PersistedProductVariationImage.self).forKey("image")
 }
 
 
+// periphery:ignore - TODO: remove ignore when populating database
 private extension PersistedProductVariation {
     enum CodingKeys: String, CodingKey {
         case id
diff --git a/Modules/Sources/Storage/GRDB/Model/PersistedProductVariationAttribute.swift b/Modules/Sources/Storage/GRDB/Model/PersistedProductVariationAttribute.swift
@@ -1,6 +1,7 @@
 import Foundation
 import GRDB
 
+// periphery:ignore - TODO: remove ignore when populating database
 public struct PersistedProductVariationAttribute: Codable {
     public private(set) var id: Int64?
     public let productVariationID: Int64
@@ -18,6 +19,8 @@ public struct PersistedProductVariationAttribute: Codable {
     }
 }
 
+// periphery:ignore - TODO: remove ignore when populating database
+// periphery:ignore - TODO: remove ignore when populating database
 extension PersistedProductVariationAttribute: FetchableRecord, MutablePersistableRecord {
     public static var databaseTableName: String { "productVariationAttribute" }
 
@@ -34,6 +37,7 @@ extension PersistedProductVariationAttribute: FetchableRecord, MutablePersistabl
 }
 
 
+// periphery:ignore - TODO: remove ignore when populating database
 private extension PersistedProductVariationAttribute {
     enum CodingKeys: String, CodingKey {
         case id
diff --git a/Modules/Sources/Storage/GRDB/Model/PersistedProductVariationImage.swift b/Modules/Sources/Storage/GRDB/Model/PersistedProductVariationImage.swift
@@ -1,6 +1,7 @@
 import Foundation
 import GRDB
 
+// periphery:ignore - TODO: remove ignore when populating database
 public struct PersistedProductVariationImage: Codable {
     public let id: Int64
     public let productVariationID: Int64
@@ -27,6 +28,7 @@ public struct PersistedProductVariationImage: Codable {
     }
 }
 
+// periphery:ignore - TODO: remove ignore when populating database
 extension PersistedProductVariationImage: FetchableRecord, PersistableRecord {
     public static var databaseTableName: String { "productVariationImage" }
 
@@ -42,6 +44,7 @@ extension PersistedProductVariationImage: FetchableRecord, PersistableRecord {
 }
 
 
+// periphery:ignore - TODO: remove ignore when populating database
 private extension PersistedProductVariationImage {
     enum CodingKeys: String, CodingKey {
         case id
diff --git a/Modules/Sources/Storage/GRDB/Model/PersistedSite.swift b/Modules/Sources/Storage/GRDB/Model/PersistedSite.swift
@@ -1,22 +1,28 @@
 import Foundation
 import GRDB
 
+// periphery:ignore - TODO: remove ignore when populating database
 public struct PersistedSite: Codable {
+    // periphery:ignore - TODO: remove ignore when populating database
     public let id: Int64
 
+    // periphery:ignore - TODO: remove ignore when populating database
     public init(id: Int64) {
         self.id = id
     }
 }
 
+// periphery:ignore - TODO: remove ignore when populating database
 extension PersistedSite: FetchableRecord, PersistableRecord {
     public static var databaseTableName: String { "site" }
 
     public enum Columns {
+        // periphery:ignore - TODO: remove ignore when populating database
         static let id = Column(CodingKeys.id)
     }
 }
 
+// periphery:ignore - TODO: remove ignore when populating database
 private extension PersistedSite {
     enum CodingKeys: String, CodingKey {
         case id
diff --git a/Modules/Sources/Storage/Protocols/Object.swift b/Modules/Sources/Storage/Protocols/Object.swift
@@ -11,6 +11,7 @@ public protocol Object: AnyObject {
 
     /// Returns an instance of ObjectID: expected to identify the current instance, unequivocally.
     ///
+    // periphery:ignore - Used in tests, no changes but mysteriously stopped being ignored.
     var objectID: ObjectID { get }
 
     /// Returns the receiver's Entity Name.
diff --git a/Modules/Sources/Yosemite/Model/Model.swift b/Modules/Sources/Yosemite/Model/Model.swift
@@ -350,12 +350,19 @@ public typealias StorageWooShippingShipment = Storage.WooShippingShipment
 public typealias StorageWooShippingOriginAddress = Storage.WooShippingOriginAddress
 
 // MARK: - GRDB Persisted Models
+// periphery:ignore - TODO: remove ignore when populating database
 public typealias PersistedSite = Storage.PersistedSite
+// periphery:ignore - TODO: remove ignore when populating database
 public typealias PersistedProduct = Storage.PersistedProduct
+// periphery:ignore - TODO: remove ignore when populating database
 public typealias PersistedProductAttribute = Storage.PersistedProductAttribute
+// periphery:ignore - TODO: remove ignore when populating database
 public typealias PersistedProductImage = Storage.PersistedProductImage
+// periphery:ignore - TODO: remove ignore when populating database
 public typealias PersistedProductVariation = Storage.PersistedProductVariation
+// periphery:ignore - TODO: remove ignore when populating database
 public typealias PersistedProductVariationAttribute = Storage.PersistedProductVariationAttribute
+// periphery:ignore - TODO: remove ignore when populating database
 public typealias PersistedProductVariationImage = Storage.PersistedProductVariationImage
 
 // MARK: - Internal ReadOnly Models
diff --git a/Modules/Sources/Yosemite/Model/Storage/PersistedProduct+Conversions.swift b/Modules/Sources/Yosemite/Model/Storage/PersistedProduct+Conversions.swift
@@ -2,6 +2,7 @@ import Foundation
 import Storage
 
 // MARK: - PersistedProduct Conversions
+// periphery:ignore - TODO: remove ignore when populating database
 extension PersistedProduct {
     init(from posProduct: POSProduct) {
         self.init(
@@ -59,6 +60,7 @@ extension PersistedProduct {
 }
 
 // MARK: - POSProduct Storage Extensions
+// periphery:ignore - TODO: remove ignore when populating database
 extension POSProduct {
     public func save(to db: GRDBDatabaseConnection) throws {
         try db.write { db in
@@ -81,6 +83,7 @@ extension POSProduct {
 }
 
 // MARK: - PersistedProductAttribute Conversions
+// periphery:ignore - TODO: remove ignore when populating database
 extension PersistedProductAttribute {
     init(from productAttribute: ProductAttribute, productID: Int64) {
         self.init(
@@ -107,6 +110,7 @@ extension PersistedProductAttribute {
 }
 
 // MARK: - PersistedProductImage Conversions
+// periphery:ignore - TODO: remove ignore when populating database
 extension PersistedProductImage {
     init(from productImage: ProductImage, productID: Int64) {
         self.init(
diff --git a/Modules/Sources/Yosemite/Model/Storage/PersistedProductVariation+Conversions.swift b/Modules/Sources/Yosemite/Model/Storage/PersistedProductVariation+Conversions.swift
@@ -2,6 +2,7 @@ import Foundation
 import Storage
 
 // MARK: - PersistedProductVariation Conversions
+// periphery:ignore - TODO: remove ignore when populating database
 extension PersistedProductVariation {
     init(from posProductVariation: POSProductVariation) {
         self.init(
@@ -53,6 +54,7 @@ extension PersistedProductVariation {
 }
 
 // MARK: - POSProductVariation Storage Extensions
+// periphery:ignore - TODO: remove ignore when populating database
 extension POSProductVariation {
     public func save(to db: GRDBDatabaseConnection) throws {
         try db.write { db in
@@ -75,6 +77,7 @@ extension POSProductVariation {
 }
 
 // MARK: - PersistedProductVariationAttribute Conversions
+// periphery:ignore - TODO: remove ignore when populating database
 extension PersistedProductVariationAttribute {
     init(from productVariationAttribute: ProductVariationAttribute, productVariationID: Int64) {
         self.init(
@@ -94,6 +97,7 @@ extension PersistedProductVariationAttribute {
 }
 
 // MARK: - PersistedProductVariationImage Conversions
+// periphery:ignore - TODO: remove ignore when populating database
 extension PersistedProductVariationImage {
     public init(from productImage: ProductImage, productVariationID: Int64) {
         self.init(
diff --git a/Modules/Tests/YosemiteTests/Storage/PersistedProductConversionsTests.swift b/Modules/Tests/YosemiteTests/Storage/PersistedProductConversionsTests.swift
diff --git a/Modules/Tests/YosemiteTests/Storage/PersistedProductTests.swift b/Modules/Tests/YosemiteTests/Storage/PersistedProductTests.swift
diff --git a/Modules/Tests/YosemiteTests/Storage/PersistedProductVariationConversionsTests.swift b/Modules/Tests/YosemiteTests/Storage/PersistedProductVariationConversionsTests.swift
diff --git a/Modules/Tests/YosemiteTests/Storage/PersistedProductVariationTests.swift b/Modules/Tests/YosemiteTests/Storage/PersistedProductVariationTests.swift

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`import Foundation`
`2`	`2`	`import GRDB`
`3`	`3`
	`4`	`+// periphery:ignore - TODO: remove ignore when populating database`
`4`	`5`	`public struct PersistedProduct: Codable {`
`5`	`6`	`public let id: Int64`
`6`	`7`	`public let siteID: Int64`
`@@ -48,6 +49,7 @@ public struct PersistedProduct: Codable {`
`48`	`49`	`}`
`49`	`50`	`}`
`50`	`51`
	`52`	`+// periphery:ignore - TODO: remove ignore when populating database`
`51`	`53`	`extension PersistedProduct: FetchableRecord, PersistableRecord {`
`52`	`54`	`public static var databaseTableName: String { "product" }`
`53`	`55`
`@@ -72,6 +74,7 @@ extension PersistedProduct: FetchableRecord, PersistableRecord {`
`72`	`74`	`public static let attributes = hasMany(PersistedProductAttribute.self)`
`73`	`75`	`}`
`74`	`76`
	`77`	`+// periphery:ignore - TODO: remove ignore when populating database`
`75`	`78`	`private extension PersistedProduct {`
`76`	`79`	`enum CodingKeys: String, CodingKey {`
`77`	`80`	`case id`
Original file line number	Diff line number	Diff line change
`@@ -1,22 +1,28 @@`
`1`	`1`	`import Foundation`
`2`	`2`	`import GRDB`
`3`	`3`
	`4`	`+// periphery:ignore - TODO: remove ignore when populating database`
`4`	`5`	`public struct PersistedSite: Codable {`
	`6`	`+ // periphery:ignore - TODO: remove ignore when populating database`
`5`	`7`	`public let id: Int64`
`6`	`8`
	`9`	`+ // periphery:ignore - TODO: remove ignore when populating database`
`7`	`10`	`public init(id: Int64) {`
`8`	`11`	`self.id = id`
`9`	`12`	`}`
`10`	`13`	`}`
`11`	`14`
	`15`	`+// periphery:ignore - TODO: remove ignore when populating database`
`12`	`16`	`extension PersistedSite: FetchableRecord, PersistableRecord {`
`13`	`17`	`public static var databaseTableName: String { "site" }`
`14`	`18`
`15`	`19`	`public enum Columns {`
	`20`	`+ // periphery:ignore - TODO: remove ignore when populating database`
`16`	`21`	`static let id = Column(CodingKeys.id)`
`17`	`22`	`}`
`18`	`23`	`}`
`19`	`24`
	`25`	`+// periphery:ignore - TODO: remove ignore when populating database`
`20`	`26`	`private extension PersistedSite {`
`21`	`27`	`enum CodingKeys: String, CodingKey {`
`22`	`28`	`case id`