Skip to content

Commit d3a39df

Browse files
authored
Merge pull request #8093 from woocommerce/task/kUTType-deprecated-ios-15
kUTType was deprecated in iOS15, use UTType instead
2 parents f454995 + 71b42df commit d3a39df

File tree

4 files changed

+12
-9
lines changed

4 files changed

+12
-9
lines changed

Yosemite/Yosemite/Tools/Media/MediaAssetExporter.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ final class MediaAssetExporter: MediaExporter {
5050
if let resource = resources.first {
5151
resourceAvailableLocally = true
5252
filename = resource.originalFilename
53-
if UTTypeEqual(resource.uniformTypeIdentifier as CFString, kUTTypeGIF) {
53+
if resource.uniformTypeIdentifier == UTType.gif.identifier {
5454
// Handles GIF export differently from images.
5555
exportGIF(forAsset: asset, resource: resource, onCompletion: onCompletion)
5656
return
@@ -112,7 +112,7 @@ private extension MediaAssetExporter {
112112
return nil
113113
}
114114
guard allowableFileExtensions.contains(fileExtensionForType) else {
115-
return kUTTypeJPEG as String
115+
return UTType.jpeg.identifier
116116
}
117117
return uti
118118
}
@@ -123,7 +123,7 @@ private extension MediaAssetExporter {
123123
/// - parameter onError: Called if an error was encountered during export.
124124
///
125125
private func exportGIF(forAsset asset: PHAsset, resource: PHAssetResource, onCompletion: @escaping MediaExportCompletion) {
126-
guard UTTypeEqual(resource.uniformTypeIdentifier as CFString, kUTTypeGIF) else {
126+
guard resource.uniformTypeIdentifier == UTType.gif.identifier else {
127127
onCompletion(nil, AssetExportError.expectedPHAssetGIFType)
128128
return
129129
}

Yosemite/Yosemite/Tools/Media/MediaImageExporter.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import Foundation
2+
import UniformTypeIdentifiers
23
import MobileCoreServices
34

45
/// Available options for an image export.
@@ -75,7 +76,7 @@ final class MediaImageExporter: MediaExporter {
7576
typeHint: String?,
7677
onCompletion: @escaping MediaExportCompletion) {
7778
do {
78-
let hint = typeHint ?? kUTTypeJPEG as String
79+
let hint = typeHint ?? UTType.jpeg.identifier
7980
let sourceOptions: [String: Any] = [kCGImageSourceTypeIdentifierHint as String: hint as CFString]
8081
guard let source = CGImageSourceCreateWithData(data as CFData, sourceOptions as CFDictionary) else {
8182
throw ImageExportError.imageSourceCreationWithDataFailed

Yosemite/YosemiteTests/Tools/Media/MediaImageExporterTests.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
import MobileCoreServices
22
import XCTest
3+
import UniformTypeIdentifiers
34
@testable import Yosemite
45

56
final class MediaImageExporterTests: XCTestCase {
67
func testExportingAnImageWithTypeHint() {
78
// Loads the test image into png data.
89
let mockData = UIImage(named: "image", in: Bundle(for: type(of: self)), compatibleWith: nil)!.pngData()
910
let filename = "test"
10-
let typeHint = kUTTypeJPEG as String
11+
let typeHint = UTType.jpeg.identifier
1112
let mockImageSourceWriter = MockImageSourceWriter()
1213
let exporter = MediaImageExporter(data: mockData!,
1314
filename: filename,
@@ -65,7 +66,7 @@ final class MediaImageExporterTests: XCTestCase {
6566
func testExportingNonImageData() {
6667
let mockData = Data()
6768
let filename = "test"
68-
let typeHint = kUTTypeJPEG as String
69+
let typeHint = UTType.jpeg.identifier
6970
let mockImageSourceWriter = MockImageSourceWriter()
7071
let exporter = MediaImageExporter(data: mockData,
7172
filename: filename,

Yosemite/YosemiteTests/Tools/Media/URL+MediaTests.swift

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import MobileCoreServices
22
import XCTest
3+
import UniformTypeIdentifiers
34
@testable import Yosemite
45

56
final class URL_MediaTests: XCTestCase {
@@ -38,16 +39,16 @@ final class URL_MediaTests: XCTestCase {
3839

3940
func testFileExtensionForJPEGType() {
4041
let expectedFileExtension = "jpeg"
41-
XCTAssertEqual(URL.fileExtensionForUTType(kUTTypeJPEG as String), expectedFileExtension)
42+
XCTAssertEqual(URL.fileExtensionForUTType(UTType.jpeg.identifier), expectedFileExtension)
4243
}
4344

4445
func testFileExtensionForGIFType() {
4546
let expectedFileExtension = "gif"
46-
XCTAssertEqual(URL.fileExtensionForUTType(kUTTypeGIF as String), expectedFileExtension)
47+
XCTAssertEqual(URL.fileExtensionForUTType(UTType.gif.identifier), expectedFileExtension)
4748
}
4849

4950
func testFileExtensionForPNGType() {
5051
let expectedFileExtension = "png"
51-
XCTAssertEqual(URL.fileExtensionForUTType(kUTTypePNG as String), expectedFileExtension)
52+
XCTAssertEqual(URL.fileExtensionForUTType(UTType.png.identifier), expectedFileExtension)
5253
}
5354
}

0 commit comments

Comments
 (0)