Remove unused code

Author: staskus

Modules/Sources/Yosemite/PointOfSale/OrderList/POSOrder.swift

@@ -19,7 +19,6 @@ public struct POSOrder: Equatable, Hashable {
     public let lineItems: [POSOrderItem]
     public let refunds: [POSOrderRefund]
     public let currency: String
-    public let currencySymbol: String
     public let discountTotal: String
     public let totalTax: String
 
@@ -35,7 +34,6 @@ public struct POSOrder: Equatable, Hashable {
                 lineItems: [POSOrderItem] = [],
                 refunds: [POSOrderRefund] = [],
                 currency: String,
-                currencySymbol: String,
                 discountTotal: String,
                 totalTax: String) {
         self.id = id
@@ -50,7 +48,6 @@ public struct POSOrder: Equatable, Hashable {
         self.lineItems = lineItems
         self.refunds = refunds
         self.currency = currency
-        self.currencySymbol = currencySymbol
         self.discountTotal = discountTotal
         self.totalTax = totalTax
     }
@@ -81,7 +78,6 @@ public extension POSOrder {
             lineItems: posLineItems,
             refunds: posRefunds,
             currency: order.currency,
-            currencySymbol: order.currencySymbol,
             discountTotal: order.discountTotal,
             totalTax: order.totalTax
         )

WooCommerce/Classes/POS/Presentation/Orders/PointOfSaleOrderDetailsView.swift

@@ -134,7 +134,8 @@ private extension PointOfSaleOrderDetailsView {
     }
 
     func imageSource(for item: POSOrderItem) -> String? {
-        return nil
+        // TODO: Will be addressed in the following PR
+        return "\(item.productID - item.variationID)"
     }
 
     @ViewBuilder
@@ -288,12 +289,6 @@ private extension PointOfSaleOrderDetailsView {
 // MARK: - Localization
 
 private enum Localization {
-    static let orderDetailsTitle = NSLocalizedString(
-        "pos.orderDetailsView.title",
-        value: "Order Details",
-        comment: "Title for the order details screen when no specific order is selected"
-    )
-
     static func orderTitle(_ orderNumber: String) -> String {
         let format = NSLocalizedString(
             "pos.orderDetailsView.orderTitle",

WooCommerce/Classes/POS/Utils/PreviewHelpers.swift

@@ -276,7 +276,6 @@ struct POSPreviewHelpers {
             ],
             refunds: [],
             currency: "USD",
-            currencySymbol: "$",
             discountTotal: "0.00",
             totalTax: "3.76"
         )
@@ -322,7 +321,6 @@ final class PointOfSalePreviewOrderListController: PointOfSaleOrderListControlle
                         ],
                         refunds: [],
                         currency: "USD",
-                        currencySymbol: "$",
                         discountTotal: "-5.24",
                         totalTax: "4.75"
                     ),
@@ -373,7 +371,6 @@ final class PointOfSalePreviewOrderListController: PointOfSaleOrderListControlle
                             )
                         ],
                         currency: "USD",
-                        currencySymbol: "$",
                         discountTotal: "-15.00",
                         totalTax: "8.95"
                     ),
@@ -404,7 +401,6 @@ final class PointOfSalePreviewOrderListController: PointOfSaleOrderListControlle
                         ],
                         refunds: [],
                         currency: "USD",
-                        currencySymbol: "$",
                         discountTotal: "0.00",
                         totalTax: "0.00"
                     ),
@@ -438,7 +434,6 @@ final class PointOfSalePreviewOrderListController: PointOfSaleOrderListControlle
                         ],
                         refunds: [],
                         currency: "USD",
-                        currencySymbol: "$",
                         discountTotal: "0.00",
                         totalTax: "3.25"
                     ),
@@ -495,7 +490,6 @@ final class PointOfSalePreviewOrderListController: PointOfSaleOrderListControlle
                             POSOrderRefund(refundID: 5, total: "-8.25", reason: nil)
                         ],
                         currency: "USD",
-                        currencySymbol: "$",
                         discountTotal: "-25.00",
                         totalTax: "7.89"
                     ),
@@ -526,7 +520,6 @@ final class PointOfSalePreviewOrderListController: PointOfSaleOrderListControlle
                         ],
                         refunds: [],
                         currency: "USD",
-                        currencySymbol: "$",
                         discountTotal: "0.00",
                         totalTax: "0.00"
                     )

WooCommerce/WooCommerceTests/POS/Mocks/MockPointOfSaleOrderListService.swift

@@ -102,7 +102,6 @@ extension MockPointOfSaleOrderListService {
             ],
             refunds: [],
             currency: "USD",
-            currencySymbol: "$",
             discountTotal: "0.00",
             totalTax: "0.00"
         )
@@ -132,7 +131,6 @@ extension MockPointOfSaleOrderListService {
             ],
             refunds: [],
             currency: "USD",
-            currencySymbol: "$",
             discountTotal: "0.00",
             totalTax: "0.00"
         )
@@ -179,7 +177,6 @@ extension MockPointOfSaleOrderListService {
             ],
             refunds: [],
             currency: "USD",
-            currencySymbol: "$",
             discountTotal: "0.00",
             totalTax: "0.00"
         )
@@ -211,7 +208,6 @@ extension MockPointOfSaleOrderListService {
                 POSOrderRefund(refundID: 1001, total: "-12.00", reason: "Customer request")
             ],
             currency: "USD",
-            currencySymbol: "$",
             discountTotal: "0.00",
             totalTax: "0.00"
         )

WooCommerce/WooCommerceTests/POS/ViewHelpers/PointOfSaleOrderDetailsViewHelperTests.swift

@@ -413,7 +413,6 @@ private func makePOSOrder(
     lineItems: [POSOrderItem] = [],
     refunds: [POSOrderRefund] = [],
     currency: String = "USD",
-    currencySymbol: String = "$",
     discountTotal: String = "0.00",
     totalTax: String = "0.00"
 ) -> POSOrder {
@@ -430,7 +429,6 @@ private func makePOSOrder(
         lineItems: lineItems,
         refunds: refunds,
         currency: currency,
-        currencySymbol: currencySymbol,
         discountTotal: discountTotal,
         totalTax: totalTax
     )